Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Go canonical import paths #29014

Closed
thockin opened this issue Jul 15, 2016 · 6 comments
Closed

Use Go canonical import paths #29014

thockin opened this issue Jul 15, 2016 · 6 comments
Labels
area/kubelet kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@thockin
Copy link
Member

thockin commented Jul 15, 2016

I think we should follow https://golang.org/doc/go1.4#canonicalimports and decorate all of our packages with their canonical paths. It's sort of tedious, but I have heard a few people who were unhappy that our code lives in github.com/kubernetes/kubernetes, but our go import is k8s.io/kubernetes.

This should at least cause a more obvious error.

I suppose that means that every package gets a doc.go with this declaration.
@thockin thockin added help-wanted kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 15, 2016
@thockin thockin mentioned this issue Jul 15, 2016
Closed
dims added a commit to dims/kubernetes that referenced this issue Jul 16, 2016
@dims
Use Go canonical import paths
2b0ed01 
Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes kubernetes#29014
@dims dims mentioned this issue Jul 16, 2016
Merged
@dims
Copy link
Member

dims commented Jul 16, 2016

@thockin ack. i started with a PR to fix existing doc.go's

k8s-github-robot pushed a commit that referenced this issue Jul 18, 2016
Merge pull request #29042 from dims/fixup-imports
fa174bc 
Automatic merge from submit-queue

Use Go canonical import paths

Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes #29014
zefciu pushed a commit to zefciu/kubernetes that referenced this issue Jul 28, 2016
@dims @zefciu
Use Go canonical import paths
6cd048a 
Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes kubernetes#29014
@luxas luxas mentioned this issue Oct 15, 2016
Merged
@luxas
Copy link
Member

luxas commented Oct 15, 2016

@dims Seems like this is only half-finished...
Will you continue with adding doc.go files to those directories who haven't got it?

@luxas luxas reopened this Oct 15, 2016
@k8s-github-robot k8s-github-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 15, 2016
@luxas
Copy link
Member

luxas commented Oct 15, 2016

We should have a verification test for this as well

cc @mikedanese @ixdy

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2018
dims added a commit to dims/kubernetes that referenced this issue Feb 8, 2018
@dims
Use Go canonical import paths
ff409da 
Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes kubernetes#29014
dims pushed a commit to dims/kubernetes that referenced this issue Feb 8, 2018
Merge pull request kubernetes#29042 from dims/fixup-imports
dd197de 
Automatic merge from submit-queue

Use Go canonical import paths

Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes kubernetes#29014
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@gyuho gyuho mentioned this issue Jul 27, 2018
Closed
16 tasks
@dims dims mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubelet kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dims @luxas @thockin @k8s-github-robot @k8s-ci-robot @fejta-bot