Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-proxy conntrack-max flag should scale by machine size #28867

Closed
thockin opened this issue Jul 13, 2016 · 1 comment
Closed

kube-proxy conntrack-max flag should scale by machine size #28867

thockin opened this issue Jul 13, 2016 · 1 comment
Labels
area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network.
Milestone
v1.3

Comments

@thockin
Copy link
Member

thockin commented Jul 13, 2016

This seems like very low-hanging fruit and hugely impactful. 256K might suffice for 4 or 8 core machines, but it's not enough for 32 core machines.

I heard a couple grumbles from people regarding 1.3 - maybe we should make this a patch for 1.3.1 or 1.3.2.

@matchstick @girishkalele @roberthbailey objections? I think this can be pretty surgical.
@thockin thockin added sig/network Categorizes an issue or PR as relevant to SIG Network. area/kube-proxy labels Jul 13, 2016
@thockin thockin added this to the v1.3 milestone Jul 13, 2016
@thockin thockin mentioned this issue Jul 13, 2016
Merged
@roberthbailey
Copy link
Contributor

I don't see any issues cherry picking a fix for this into the 1.3 branch.

k8s-github-robot pushed a commit that referenced this issue Jul 16, 2016
Merge pull request #28876 from thockin/kube-proxy-scale-conntrack-by-…
6f98b69 
…cores

Automatic merge from submit-queue

Scale kube-proxy conntrack limits by cores (new default behavior)

For large machines we want more conntrack entries than smaller machines.

Commence bike-shedding on names and values and semantics.  I'd love to get this in as a patch to 1.3.x since we have had some trouble for users on large machines.

Fixes #28867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
2 participants
@thockin @roberthbailey