-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In 1.3, kubelet cloud-provider setting is not respected when --cloud-provider="" #28231
Comments
If you specify any cloud provider through flags, it will be used by kubelet (see https://github.com/kubernetes/kubernetes/blob/release-1.3/pkg/kubelet/kubelet.go#L1068). It's only when you don't specify any cloud provider that kubelet will detect the cloud provider from the machine info, as described by the comment. // If no cloud provider is defined - use the one detected by cadvisor |
that's exactly my situation, I want to run in our private cloud environment without any of the cloud integration. If I specify cloud-provider="" at runtime it will get overridden. |
Ah I see. I guess specifying an empty string is the same as not specifying any cloud provider. This auto-detection feature was introduced by #21373 |
@emaildanwilson Legitimate concern. I'm posting a fix. Do you consider this to be a regression or are you just getting started with k8s. |
@vishh Thank you. We're running on 1.2.4 and won't be running on 1.3 for a few months yet anyways and was just testing to look for future issues when I found this. |
@vishh I assigned this issue to you since you are working on a fix, and I can't assign this to @enoodle anyway :-) |
@emaildanwilson Thanks for testing our 1.3 release candidate, and reporting this regression to us. We are including the fix to 1.3. |
Automatic merge from submit-queue [kubelet] Allow opting out of automatic cloud provider detection in kubelet. By default kubelet will auto-detect cloud providers fixes #28231
Automatic merge from submit-queue [kubelet] Allow opting out of automatic cloud provider detection in kubelet. By default kubelet will auto-detect cloud providers fixes kubernetes#28231 (cherry picked from commit ab37fbf)
It appears that the kubelet will detect and use the cloud provider as detected by cadvisor thus overriding the cloud provider passed in at runtime: https://github.com/kubernetes/kubernetes/blob/release-1.3/pkg/kubelet/kubelet.go#L1117. This will break our private cloud configuration where we do not use our cloud provider's load balancing and instead use our own load balancing tier. In my opinion, the cloud provider specified at kubelet runtime should be respected for the node.
Am I reading this correctly?
Any thoughts on how to handle this properly?
Thank you!
The text was updated successfully, but these errors were encountered: