Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplicationController hooks and events #2804

Closed
bgrant0607 opened this issue Dec 9, 2014 · 3 comments
Closed

ReplicationController hooks and events #2804

bgrant0607 opened this issue Dec 9, 2014 · 3 comments
Labels
area/api Indicates an issue on api area. area/extensibility area/workload-api/replicaset lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@bgrant0607
Copy link
Member

Capturing internal email and in-person discussions.

The choice of which pod to kill when a replication controller replica count is decreased (or the replication controller otherwise detects that it somehow has too many pods) could become fairly nuanced, and even application-specific (e.g., don't kill the current master in a master-elected service). One way in which we could make the policy extensible is to generate an event that indicates pods need to be killed and then wait some amount of time. That would provide an opportunity for a user-provider pod killer to make the choice.

That's not to say that we shouldn't make the default choice more intelligent over time (e.g., taking into account application readiness), but the default policy will never satisfy everyone.

Events when pods are actually killed and created would be useful, too.

@bgrant0607 bgrant0607 added area/api Indicates an issue on api area. area/extensibility priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Dec 9, 2014
@bgrant0607 bgrant0607 changed the title ReplicationController events ReplicationController hooks and events Feb 13, 2015
@bgrant0607 bgrant0607 added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 28, 2015
@bgrant0607 bgrant0607 added area/workload-api/replicaset sig/apps Categorizes an issue or PR as relevant to SIG Apps. triaged and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 9, 2017
@0xmichalis
Copy link
Contributor

The controllers are emitting events when pods are created/deleted. Re hooks, I think this is going to be satisfied by evictionCost (#4301)

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@bgrant0607
Copy link
Member Author

Obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/extensibility area/workload-api/replicaset lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Development

No branches or pull requests

4 participants