Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The multizone setting in gce.conf is ignored by PersistentVolumeLabel #27656

Closed
justinsb opened this issue Jun 18, 2016 · 13 comments
Closed

The multizone setting in gce.conf is ignored by PersistentVolumeLabel #27656

justinsb opened this issue Jun 18, 2016 · 13 comments
Assignees
@gnufied @jingxu97
Labels
area/apiserver area/platform/gce priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Milestone
v1.6

Comments

@justinsb
Copy link
Member

gce.conf is not even read while building the GCE cloudprovider:
https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/admission/persistentvolume/label/admission.go#L176

As such, multizone is ignored, and a PV in a zone other than that in which the apiserver is running cannot be created on GCE.
@justinsb justinsb added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 18, 2016
@justinsb justinsb added this to the v1.3 milestone Jun 18, 2016
@justinsb justinsb mentioned this issue Jun 18, 2016
Closed
@justinsb
Copy link
Member Author

The most important consequence of this bug is #27657. I propose that if we can work around that we can punt this to 1.4.

justinsb added a commit to justinsb/kubernetes that referenced this issue Jun 18, 2016
@justinsb
GCE Multizone: Allow volumes to be created in non-master zone
9c25665 
We had a long-lasting bug which prevented creation of volumes in
non-master zones, because the cloudprovider in the volume label
admission controller is not initialized with the multizone setting
(issue kubernetes#27656).

This implements a simple workaround: if the volume is created with the
failure-domain zone label, we look for the volume in that zone.  This is
more efficient, avoids introducing a new semantic, and allows users (and
the dynamic provisioner) to create volumes in non-master zones.

Fixes kubernetes#27657
@justinsb
Copy link
Member Author

Workaround to justify punting in #27553

@roberthbailey roberthbailey assigned ghost Jun 18, 2016
@justinsb justinsb mentioned this issue Jun 20, 2016
Merged
chrislovecnm pushed a commit to chrislovecnm/kubernetes that referenced this issue Jun 21, 2016
@justinsb @chrislovecnm
GCE Multizone: Allow volumes to be created in non-master zone
57ce130 
We had a long-lasting bug which prevented creation of volumes in
non-master zones, because the cloudprovider in the volume label
admission controller is not initialized with the multizone setting
(issue kubernetes#27656).

This implements a simple workaround: if the volume is created with the
failure-domain zone label, we look for the volume in that zone.  This is
more efficient, avoids introducing a new semantic, and allows users (and
the dynamic provisioner) to create volumes in non-master zones.

Fixes kubernetes#27657
@goltermann
Copy link
Contributor

@justinsb, @quinton-hoole #27533 is merged - is the right thing to keep this open, but move out of v1.3?

@justinsb
Copy link
Member Author

I believe so, yes: we have a workaround that avoids the problem - you specify the zone annotations if running multizone. The dynamic provisioner specifies them automatically, so for most users volumes "just work". Punting to 1.4

@justinsb justinsb modified the milestones: v1.4, v1.3 Jun 22, 2016
@justinsb justinsb removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 22, 2016
@ghost ghost added area/cluster-federation priority/backlog Higher priority than priority/awaiting-more-evidence. sig/storage Categorizes an issue or PR as relevant to SIG Storage. area/platform/gce labels Jul 7, 2016
@matchstick matchstick assigned jingxu97 and unassigned ghost Aug 12, 2016
@matchstick matchstick added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. team/control-plane labels Aug 12, 2016
@jingxu97
Copy link
Contributor

@justinsb, Could you please let me know what is the status of the bug? It is assigned to me, but I am wondering whether you already worked on it. Also what is the appropriate priority for this issue? Thanks!

@ghost ghost added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 18, 2016
@ghost ghost added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 18, 2016
@ghost
Copy link

ghost commented Aug 22, 2016

No work done on this yet for 1.4 - punting it to the next release, given that we have a workaround.

@ghost ghost modified the milestones: v1.5, v1.4 Aug 22, 2016
@dims
Copy link
Member

dims commented Nov 10, 2016

@quinton-hoole we have to do it again...punt to 1.6 please?

@ghost ghost modified the milestones: 1.6, v1.5 Nov 11, 2016
@saad-ali saad-ali modified the milestones: v1.6, 1.6 Nov 12, 2016
@msau42
Copy link
Member

msau42 commented Mar 13, 2017

@gnufied, does #40537 fix this issue?

@gnufied
Copy link
Member

gnufied commented Mar 13, 2017

Yes it does. Lets close this one. I will backport the fix.

@gnufied
Copy link
Member

gnufied commented Mar 13, 2017

/close

@k8s-ci-robot
Copy link
Contributor

@gnufied: you can't close an issue unless you authored it or you are assigned to it.

In response to this comment:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Mar 13, 2017

/assign @gnufied

@gnufied
Copy link
Member

gnufied commented Mar 14, 2017

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnufied gnufied

@jingxu97 jingxu97

Labels
area/apiserver area/platform/gce priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
v1.6
Development

No branches or pull requests
10 participants
@gnufied @dims @justinsb @goltermann @saad-ali @k8s-github-robot @jingxu97 @matchstick @k8s-ci-robot @msau42