Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rkt: Image pull policy of 'Always' is not respected #27646

Closed
euank opened this issue Jun 17, 2016 · 0 comments
Closed

rkt: Image pull policy of 'Always' is not respected #27646

euank opened this issue Jun 17, 2016 · 0 comments
Assignees
Labels

Comments

@euank
Copy link
Contributor

euank commented Jun 17, 2016

Setting a pull policy of Always should cause the runtime to always hit the remote server for an image. However, the rkt fetch invocation used to get the image always checks the cache first, rather than hit the network.

This also impacts Always PullPolocies that are implicitly added to :latest tagged images.

The impact of this is that a ":latest" tagged image will not be updated on each new run under rktnetes, unless it has been removed. Similarly, when setting a global pull policy of Always, the image will not be updated unless removed.

cc @kubernetes/sig-rktnetes

@yifan-gu yifan-gu added this to the rktnetes-v1.1 milestone Jun 20, 2016
@yifan-gu yifan-gu self-assigned this Jun 20, 2016
@yifan-gu yifan-gu changed the title rkt: Image pull policy of 'Always' is not respeected rkt: Image pull policy of 'Always' is not respected Jun 25, 2016
k8s-github-robot pushed a commit that referenced this issue Aug 26, 2016
Automatic merge from submit-queue

rkt: Force `rkt fetch` to fetch from remote to conform the image pull policy.

Fix #27646

Use `--no-store` option for `rkt fetch` to force it to fetch from remote.
However, `--no-store` will fetch the remote image regardless of whether the content of the image has changed or not. 
This causes performance downgrade when the image tag is ':latest' and the image pull policy is 'always'. 
The issue is tracked in rkt/rkt#2937.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants