Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replication Controller doesn't notice changes in pods labels #27405

Closed
caesarxuchao opened this issue Jun 15, 2016 · 2 comments
Closed

Replication Controller doesn't notice changes in pods labels #27405

caesarxuchao opened this issue Jun 15, 2016 · 2 comments
Assignees
@caesarxuchao
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.3

Comments

@caesarxuchao
Copy link
Member

To reproduce, I create a rc, wait for its pods to be created, then modify the labels of the pod so that it doesn't match the rc's selector anymore. RC should create another pod, but it doesn't try to.

The problem is this line. It should enqueue the old rc if old rc exists.

I have a local fix for the rc manager. I'll check the replicaset controller and add a test then send the PR.

cc @bprashanth
@caesarxuchao caesarxuchao self-assigned this Jun 15, 2016
@bprashanth
Copy link
Contributor

Yeah, that got dropped somewhere along the way. This should happen: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/replication/replication_controller.go#L349
Nice catch.

@bprashanth bprashanth added this to the v1.3 milestone Jun 15, 2016
@bprashanth bprashanth added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 15, 2016
@bprashanth
Copy link
Contributor

This is important. Marking 1.3.

@caesarxuchao caesarxuchao mentioned this issue Jun 15, 2016
Merged
@davidopp davidopp added cherrypick-candidate priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 15, 2016
k8s-github-robot pushed a commit that referenced this issue Jun 17, 2016
Merge pull request #27415 from caesarxuchao/fix-oldrc
646a872 
Automatic merge from submit-queue

fix updatePod() of RS and RC controllers

Fix updatePod of replication controller manager and replica set controller to handle pod label updates that match no RC or RS.

Fix #27405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caesarxuchao caesarxuchao

Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
4 participants
@caesarxuchao @davidopp @fgrzadkowski @bprashanth