Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8sm] Run local km in agent host #26930

Closed
k82cn opened this issue Jun 7, 2016 · 7 comments · Fixed by #28447
Closed

[k8sm] Run local km in agent host #26930

k82cn opened this issue Jun 7, 2016 · 7 comments · Fixed by #28447
Assignees
@jdef
Labels
area/platform/mesos

Comments

@k82cn
Copy link
Member

k82cn commented Jun 7, 2016

I'd like to run local km in agent host. The parameters --executor-path is used to set executor, but it did not set km's arguments.

The proposal is to provide an argument --km-patch to set the local path of km in agent host.

cc @jdef
@k82cn
Copy link
Member Author

k82cn commented Jun 7, 2016

It seems we have a hidden parameter --km-path, I'll try it firstly.

https://github.com/kubernetes/kubernetes/blob/master/contrib/mesos/pkg/scheduler/service/service.go#L347

@jdef jdef self-assigned this Jun 7, 2016
@k82cn
Copy link
Member Author

k82cn commented Jun 14, 2016

@jdef any suggestion?

@jdef
Copy link
Contributor

jdef commented Jun 14, 2016

how did --km-path work out? if you ran into problems .. what were they?

@k82cn
Copy link
Member Author

k82cn commented Jun 16, 2016

Just have a try, it seems not work; I'm on sure whether configuration issue.

@k82cn
Copy link
Member Author

k82cn commented Jul 4, 2016 •
edited
Loading

@jdef , just go through the code; the --km-path will only point to the km binaries in master and Mesos agent will fetch it. It did not match this requirement.

Do you have time on this? I'd like to work on this and let you review it :).

@k82cn k82cn mentioned this issue Jul 4, 2016
Merged
@k82cn
Copy link
Member Author

k82cn commented Jul 5, 2016

@jdef , would you help to review the patch?

@jdef
Copy link
Contributor

jdef commented Jul 5, 2016

Yes, just provided some feedback on your PR

On Mon, Jul 4, 2016 at 11:24 PM, Klaus Ma notifications@github.com wrote:

@jdef https://github.com/jdef , would you help to review the patch?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26930 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ACPVLFDRoN7GLOb-A98E_-hzseox5Zydks5qSc5wgaJpZM4Ivfb_
.

k8s-github-robot pushed a commit that referenced this issue Jul 7, 2016
Merge pull request #28447 from k82/k8s-26930-km-local-path
32e5996 
Automatic merge from submit-queue

MESOS: Support a pre-installed km binary at a well known, agent-local path

fixes #26930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdef jdef

Labels
area/platform/mesos
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MESOS: Support a pre-installed km binary at a well known, agent-local path k82cn/kubernetes
2 participants
@jdef @k82cn