Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running DaemonSet only on Schedulable Nodes #26810

Closed
colemickens opened this issue Jun 3, 2016 · 11 comments
Closed

Running DaemonSet only on Schedulable Nodes #26810

colemickens opened this issue Jun 3, 2016 · 11 comments
Labels
area/workload-api/daemonset lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@colemickens
Copy link
Contributor

Today, DaemonSet Pods will be scheduled even on nodes that are marked SchedulingDisabled (node.spec.unschedulable==true).

Is there an out-of-the-box way to use a selector to select only schedulable nodes? Or is the user required to manually label their nodes and then use an appropriate selector?

CC: @theobolo

@dchen1107
Copy link
Member

cc/ @Random-Liu We ran into the similar issue with node problem detector.

@Random-Liu
Copy link
Member

XRef kubernetes/node-problem-detector#13 for similar issue we encountered in node problem detector.

@therc
Copy link
Member

therc commented Jun 5, 2016

For the record, I have been relying on this behaviour for months. I have kubelet running on my master nodes with --register-schedulable=false. That way, normal pods won't schedule, but the fluentd DaemonSet does.

@colemickens
Copy link
Contributor Author

Yes, I need the same thing. I'm not proposing changing that behavior, just adding some sort of label for --register-schedulable=false machines that can be easily used in a DaemonSet selector. (Or documentation of it if such a label already exists.)

@lukaszo
Copy link
Contributor

lukaszo commented Jun 28, 2016

I believe it's tracked here #22205

@colemickens
Copy link
Contributor Author

I believe that #22205 is about having the scheduler respect affinity contraints for daemonset pods.

In this case, the scheduler already knows how to use node selectors... I'm just seeking to have kubelet automatically label nodes that are marked --register-schedulable=false so that I can use that label in the daemonset's node selector.

(Unless there's already a label/mechanism to do this?)

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@0xmichalis
Copy link
Contributor

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jun 22, 2017
@0xmichalis
Copy link
Contributor

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Jun 22, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 22, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/workload-api/daemonset lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

No branches or pull requests

9 participants