Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include federation e2e in merge bot testing #26723

Closed
nikhiljindal opened this issue Jun 2, 2016 · 17 comments
Closed

include federation e2e in merge bot testing #26723

nikhiljindal opened this issue Jun 2, 2016 · 17 comments
Assignees
Labels
area/federation area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.

Comments

@nikhiljindal
Copy link
Contributor

We should include federation e2e in merge bot testing, so that we can catch PRs that break the test.
We need to ensure that it is 100% green before doing this.

@colhom Can you take this up?

cc @kubernetes/sig-cluster-federation

@ghost
Copy link

ghost commented Jun 2, 2016

I can take this. Lets focus on getting them all green first though.

@ghost ghost added this to the v1.3 milestone Jun 2, 2016
@ghost ghost self-assigned this Jun 2, 2016
@nikhiljindal
Copy link
Contributor Author

@quinton-hoole can you detail the steps that are required?
It will be good to get a PR ready.

@ghost
Copy link

ghost commented Jun 13, 2016

@nikhiljindal I don't know the precise steps offhand, but in essence there are two parts:

  1. the merge-bot configuration needs to be updated to to include the "kubernetes-e2e-gce-federation" test job as a merge-blocker. That way, if that job is failing, automated merges will be blocked.
  2. the per-PR merge bot needs to be updated to deploy the federation control plane into the e2e test cluster, and add "--test_args="--ginkgo.focus=[Feature:Federation]" to the e2e tests that are run on every PR. This will ensure that the federation e2e tests are run (against a federation which includes only a single underlying cluster) for every PR. We can extend this to multiple clusters as a second step (as this might be slightly more difficult to configure).

@goltermann
Copy link
Contributor

goltermann commented Jun 13, 2016

Applying P1 priority (should do for 1.3) - adjust if that's not right.

@goltermann goltermann added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 13, 2016
@nikhiljindal
Copy link
Contributor Author

cc @lavalamp

@lavalamp
Copy link
Member

the per-PR merge bot needs to be updated to deploy the federation control plane into the e2e test cluster, and add "--test_args="--ginkgo.focus=[Feature:Federation]" to the e2e tests that are run on every PR. This will ensure that the federation e2e tests are run (against a federation which includes only a single underlying cluster) for every PR. We can extend this to multiple clusters as a second step (as this might be slightly more difficult to configure)

You can only do this if it doesn't make the test take longer! Needs to stay under 30 minutes.

@ghost
Copy link

ghost commented Jun 13, 2016

Agreed, that is part of what I meant by "more difficult" :-)

@nikhiljindal
Copy link
Contributor Author

Created a test-infra issue for the second item as per discussion with @ixdy
kubernetes/test-infra#155

@matchstick matchstick added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jun 22, 2016
@goltermann goltermann modified the milestones: next-candidate, v1.3 Jun 27, 2016
@ghost ghost assigned nikhiljindal and unassigned ghost Aug 11, 2016
@ghost
Copy link

ghost commented Aug 11, 2016

@nikhiljindal seems to have this done. Reassigning.

@nikhiljindal nikhiljindal modified the milestones: v1.4, next-candidate Aug 12, 2016
@nikhiljindal nikhiljindal added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 12, 2016
@ghost
Copy link

ghost commented Aug 18, 2016

This is done in kubernetes/test-infra#335. Closing.

@ghost ghost closed this as completed Aug 18, 2016
@nikhiljindal
Copy link
Contributor Author

Yes that PR was merged. But the test is still not passing on Jenkins. federation-apiserver pod fails to come up. I am trying to figure out how to get logs (We dont get pod logs right now)

@nikhiljindal nikhiljindal reopened this Aug 19, 2016
@ghost ghost added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 25, 2016
@goltermann
Copy link
Contributor

@nikhiljindal @quinton-hoole are these passing now? Is this issue a 1.4 blocker?

@madhusudancs
Copy link
Contributor

@goltermann federation tests are passing, but this issue isn't completely resolved. This isn't a 1.4 blocker. Re-targeting to 1.5.

@madhusudancs madhusudancs modified the milestones: v1.5, v1.4 Sep 7, 2016
@dims
Copy link
Member

dims commented Nov 16, 2016

@madhusudancs : is this still target-ted for 1.5?

@saad-ali
Copy link
Member

@nikhiljindal @kubernetes/sig-cluster-federation I am marking this as non-release blocking for 1.5.

FYI the federation E2E suite for release-1.5 is ci-kubernetes-e2e-gce-federation-release-1.5

@nikhiljindal nikhiljindal removed this from the v1.5 milestone Nov 18, 2016
@nikhiljindal
Copy link
Contributor Author

Yes removed from 1.5 milestone

@irfanurrehman
Copy link
Contributor

This issue was labelled only for sig/multicluster and is thus moved over to kubernetes-retired/federation#46.
If this does not seem to be right, please reopen this and notify us @kubernetes/sig-multicluster-misc.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/federation area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Projects
None yet
Development

No branches or pull requests