-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include federation e2e in merge bot testing #26723
Comments
I can take this. Lets focus on getting them all green first though. |
@quinton-hoole can you detail the steps that are required? |
@nikhiljindal I don't know the precise steps offhand, but in essence there are two parts:
|
Applying P1 priority (should do for 1.3) - adjust if that's not right. |
cc @lavalamp |
You can only do this if it doesn't make the test take longer! Needs to stay under 30 minutes. |
Agreed, that is part of what I meant by "more difficult" :-) |
Created a test-infra issue for the second item as per discussion with @ixdy |
@nikhiljindal seems to have this done. Reassigning. |
This is done in kubernetes/test-infra#335. Closing. |
Yes that PR was merged. But the test is still not passing on Jenkins. federation-apiserver pod fails to come up. I am trying to figure out how to get logs (We dont get pod logs right now) |
@nikhiljindal @quinton-hoole are these passing now? Is this issue a 1.4 blocker? |
@goltermann federation tests are passing, but this issue isn't completely resolved. This isn't a 1.4 blocker. Re-targeting to 1.5. |
@madhusudancs : is this still target-ted for 1.5? |
@nikhiljindal @kubernetes/sig-cluster-federation I am marking this as non-release blocking for 1.5. FYI the federation E2E suite for release-1.5 is ci-kubernetes-e2e-gce-federation-release-1.5 |
Yes removed from 1.5 milestone |
This issue was labelled only for sig/multicluster and is thus moved over to kubernetes-retired/federation#46. |
We should include federation e2e in merge bot testing, so that we can catch PRs that break the test.
We need to ensure that it is 100% green before doing this.
@colhom Can you take this up?
cc @kubernetes/sig-cluster-federation
The text was updated successfully, but these errors were encountered: