Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-gen] Add patch methods to the clientset #26580

Closed
caesarxuchao opened this issue May 31, 2016 · 2 comments
Closed

[client-gen] Add patch methods to the clientset #26580

caesarxuchao opened this issue May 31, 2016 · 2 comments
Assignees
@caesarxuchao
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@caesarxuchao
Copy link
Member

And we should support patch of subresources.

Example use cases include kubernetes/node-problem-detector#11.
@caesarxuchao caesarxuchao added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label May 31, 2016
@caesarxuchao caesarxuchao self-assigned this May 31, 2016
@caesarxuchao caesarxuchao mentioned this issue May 31, 2016
Merged
@caesarxuchao caesarxuchao mentioned this issue Jun 13, 2016
Merged
@hongchaodeng
Copy link
Contributor

Is it "PATCH" for all api objects?

@caesarxuchao
Copy link
Member Author

@hongchaodeng yes, for all the objects that are already supported by the clientset.

k8s-github-robot pushed a commit that referenced this issue Jun 26, 2016
Merge pull request #27293 from caesarxuchao/add-patch-to-clientset
9303784 
Automatic merge from submit-queue

[client-gen]Add Patch to clientset

* add the Patch() method to the clientset. 
* I have to rename the existing Patch() method of `Event` to PatchWithEventNamespace() to avoid overriding.
* some minor changes to the fake Patch action.

cc @Random-Liu since he asked for the method
@kubernetes/sig-api-machinery 

ref #26580 

```release-note
Add the Patch method to the generated clientset.
```
@caesarxuchao caesarxuchao mentioned this issue Jul 12, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 13, 2016
Merge pull request #28820 from caesarxuchao/patch-subresource
6b6141f 
Automatic merge from submit-queue

[client-gen] Allow passing subresources in Patch method

Expand the Patch() method from:
```
Patch(name string, pt api.PatchType, data []byte)
```
to
```
Patch(name string, pt api.PatchType, data []byte, subresources ...string)
```

Continue on #27293. Fixes #26580.

cc @Random-Liu @lavalamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caesarxuchao caesarxuchao

Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hongchaodeng @caesarxuchao