@sttts i am trying kubectl 1.2.4 and i see

$ ./kubectl exec -it sleep-548116132-yf6wd -- /bin/sh -c "exit 5"
error: error executing remote command: error executing command in container: Error executing in Docker Container: 5

@dims that's right. But the return code in the shell of the whole command is 1, compare $?.

@sttts ack, just making sure we are seeing the same thing :)

Haven't looked into the code yet. Not sure cobra supports that.

@sttts looks like kubelet itself is treating exit code and the error stream as one thing. This will take some non-trivial work i think

I don't want to introduce another stream for the return code only. I would propose to switch the error stream protocol to json, e.g. {message: "the old message string", code: 42}. Looking at #25273 for resize events, it seems to be a good moment to add this with protocol v3.

Opinions @dims @ncdc ?

@sttts - just for error stream. yes, i think that would be good!

Yes that's what I had been thinking as well.

On Monday, May 30, 2016, Dr. Stefan Schimanski notifications@github.com
wrote:

I don't want to introduce another stream for the return code only. I would
propose to switch the error stream protocol to json, e.g. {message: "the
old message string", code: 42}. Looking at #25273
#25273 for resize events,
it seems to be a good moment to add this with protocol v3.

Opinions @dims https://github.com/dims @ncdc https://github.com/ncdc ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26424 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAABYo4w4do_co2X0odis3W2ALRc-o83ks5qGshLgaJpZM4Iojdc
.

Do you want to bundle this in with my terminal resizing pull, or try to
maybe do it right set it merges?

On Monday, May 30, 2016, Andy Goldstein agoldste@redhat.com wrote:

Yes that's what I had been thinking as well.

On Monday, May 30, 2016, Dr. Stefan Schimanski <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I don't want to introduce another stream for the return code only. I
would propose to switch the error stream protocol to json, e.g. {message:
"the old message string", code: 42}. Looking at #25273
#25273 for resize events,
it seems to be a good moment to add this with protocol v3.

Opinions @dims https://github.com/dims @ncdc https://github.com/ncdc
?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#26424 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAABYo4w4do_co2X0odis3W2ALRc-o83ks5qGshLgaJpZM4Iojdc
.

@ncdc working on it right now. Makes sense to put that on-top of your PR.

Looks like PR #26541 is close to merging.

Waiting for #25273 to go in.

--attach=true --restart=Never returns with the pod's exit code :)