Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test flake: kubectl edit can update the image field of a pod (hack/test-cmd.sh) #25925

Closed
brendandburns opened this issue May 19, 2016 · 3 comments
Closed

integration test flake: kubectl edit can update the image field of a pod (hack/test-cmd.sh) #25925

brendandburns opened this issue May 19, 2016 · 3 comments
Assignees
@janetkuo
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@brendandburns
Copy link
Contributor 

...
FAIL!
Get pods {{range.items}}{{(index .spec.containers 0).image}}:{{end}}
  Expected: gcr.io/google_containers/serve_hostname:
  Got:      nginx:
�(B
714 ./hack/test-cmd.sh

https://pantheon.corp.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/25894/kubernetes-pull-test-unit-integration/26773/
@brendandburns brendandburns added the kind/flake Categorizes issue or PR as related to a flaky test. label May 19, 2016
@brendandburns brendandburns mentioned this issue May 19, 2016
Merged
@bgrant0607 bgrant0607 added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/ux labels May 20, 2016
@bgrant0607
Copy link
Member

cc @kubernetes/kubectl

@janetkuo janetkuo self-assigned this May 23, 2016
@janetkuo
Copy link
Member

Edit cancelled, no valid changes were saved.

Somehow the edit command didn't edit the resource.

@janetkuo janetkuo mentioned this issue May 23, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue May 24, 2016
Merge pull request #26115 from janetkuo/edit-pod-flake
ac3b315 
Automatic merge from submit-queue

Add pre-condition before editing pod in test-cmd.sh

Ref #25925

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()
@janetkuo janetkuo changed the title kubectl edit can update the image field of a pod is flaky integration test flake: kubectl edit can update the image field of a pod (hack/test-cmd.sh) May 24, 2016
@brendandburns
Copy link
Contributor Author

I actually think this was caused by something in my PR. closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janetkuo @brendandburns @bgrant0607 @pwittrock