Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl autoscale prevents CPU percentages over 100% #25815

Closed
DirectXMan12 opened this issue May 18, 2016 · 3 comments
Closed

kubectl autoscale prevents CPU percentages over 100% #25815

DirectXMan12 opened this issue May 18, 2016 · 3 comments
Assignees
@jszczepkowski
Labels
area/kubectl priority/backlog Higher priority than priority/awaiting-more-evidence. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.

Comments

@DirectXMan12
Copy link
Contributor

In #18294, it was decided that CPU percentages over 100% on the HPA were valid, but should be warned about. However, kubectl autoscale prevents you from passing --cpu-percent=X when X is over 100.

It seems confusing that if you create an autoscaler with autoscale it will prevent target CPU percentages over 100%, but after you create it, you can go in and edit it to be over 100% (or you could just create it with a value over 100% by creating via YAML).

We should probably change kubectl autoscale to just warn to be consistent.

cc @janetkuo @piosz @kubernetes/autoscaling @ncdc
@0xmichalis
Copy link
Contributor

@kubernetes/kubectl

@0xmichalis 0xmichalis added priority/backlog Higher priority than priority/awaiting-more-evidence. area/kubectl sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels May 18, 2016
@piosz
Copy link
Member

piosz commented May 24, 2016

cc @jszczepkowski

@jszczepkowski
Copy link
Contributor

We should probably change kubectl autoscale to just warn to be consistent.

+1

jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue May 24, 2016
@jszczepkowski
Fixed check in kubectl autoscale.
47a5c17 
Fixed check in kubectl autoscale: cpu consumption can be higher than 100%. Fixes kubernetes#25815.
@jszczepkowski jszczepkowski mentioned this issue May 24, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue May 31, 2016
Merge pull request #26162 from jszczepkowski/kubectl-fix2
c805303 
Automatic merge from submit-queue

Fixed check in kubectl autoscale.

```release-note
Fixed check in kubectl autoscale: cpu consumption can be higher than 100%.
```

[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()

Fixed check in kubectl autoscale: cpu consumption can be higher than 100%. Fixes #25815.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jszczepkowski jszczepkowski

Labels
area/kubectl priority/backlog Higher priority than priority/awaiting-more-evidence. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@DirectXMan12 @lavalamp @0xmichalis @piosz @jszczepkowski