Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-cmd flake: kubectl rollout pause deployments --recursive #25645

Closed
krousey opened this issue May 16, 2016 · 9 comments · Fixed by #26243
Closed

test-cmd flake: kubectl rollout pause deployments --recursive #25645

krousey opened this issue May 16, 2016 · 9 comments · Fixed by #26243
Assignees
@janetkuo
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@krousey
Copy link
Contributor

krousey commented May 16, 2016 

FAIL!
Get deployment {{range.items}}{{.spec.paused}}:{{end}}
  Expected: true:true:
  Got:      <no value>:true:
�(B
1090 ./hack/test-cmd.sh

https://pantheon.corp.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/25221/kubernetes-pull-test-unit-integration/25998/
@krousey krousey added the kind/flake Categorizes issue or PR as related to a flaky test. label May 16, 2016
@krousey krousey mentioned this issue May 16, 2016
Merged
@nikhiljindal
Copy link
Contributor

cc @janetkuo

@brendandburns brendandburns mentioned this issue May 17, 2016
Merged
@deads2k deads2k mentioned this issue May 17, 2016
Merged
@spxtr spxtr mentioned this issue May 18, 2016
Merged
@fejta
Copy link
Contributor

fejta commented May 23, 2016

Assigning to @janetkuo per test-cmd.sh

@pwittrock pwittrock added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 23, 2016
@jingxu97 jingxu97 mentioned this issue May 24, 2016
Merged
@0xmichalis 0xmichalis mentioned this issue May 24, 2016
Merged
@mikedanese
Copy link
Member

mikedanese commented May 24, 2016 •
edited
Loading

Flaked again https://console.cloud.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/26190/kubernetes-pull-test-unit-integration/27676/

@mikedanese mikedanese mentioned this issue May 24, 2016
Closed
@janetkuo janetkuo changed the title test-cmd flake: Rollback a deployment test-cmd flake: Pause a deployment May 25, 2016
@janetkuo
Copy link
Member

janetkuo commented May 25, 2016 •
edited
Loading

The flake actually happened when pausing the deployment. Changing issue title.

@janetkuo
Copy link
Member

When kubectl rollout pause -f hack/testdata/recursive/deployment --recursive, sometimes one of the deployments isn't paused.

cc @metral @Kargakis

@janetkuo janetkuo changed the title test-cmd flake: Pause a deployment test-cmd flake: kubectl rollout pause deployments --recursive May 25, 2016
@metral
Copy link
Contributor

metral commented May 25, 2016

I can't access the internal Google logs to examine the cause, nor can I reproduce this issue locally. Is there any additional information that you can provide to help troubleshoot the flake?

@metral metral mentioned this issue May 25, 2016
Merged
@metral
Copy link
Contributor

metral commented May 25, 2016

I've gone ahead and attempted a fix for this in #26243

@0xmichalis
Copy link
Contributor

We should fix this in #20437 eventually

@janetkuo
Copy link
Member

@metral the external links are here (s/pantheon.corp/console.cloud):
https://console.cloud.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/25221/kubernetes-pull-test-unit-integration/25998/
https://console.cloud.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/26190/kubernetes-pull-test-unit-integration/27676/

k8s-github-robot pushed a commit that referenced this issue May 26, 2016
Merge pull request #26243 from metral/fix-pause
128e7f1 
Automatic merge from submit-queue

use kubectl-with-retry on pause & resume

attempts to fix #25645 by using `kubectl-with-retry` on `rollout {pause,resume}` (`resume` is for safe measures) instead of `kubectl` directly, as is done with other `rollout {pause,resume}` tests in this same script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janetkuo janetkuo

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use kubectl-with-retry on pause & resume metral/kubernetes
9 participants
@krousey @fejta @metral @mikedanese @0xmichalis @janetkuo @bgrant0607 @pwittrock @nikhiljindal