-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake e2e node conformance test failure #25169
Comments
cc @Random-Liu |
@pwittrock @liangchenye For short, event though the pod is deleted on the apiserver, kubelet may still try to delete the pod again. If we create a pod with the same name and namespace soon after deleting the it, the new pod will be deleted by kubelet accidentally.
This is the same with #24937. This should have caused quite a few flakes, bump up the priority. /cc @yujuhong |
Great. Seems like we have a quick fix then. |
Don't we check the pod UID before deleting it? |
@yujuhong But there is still a race between kubelet and apiserver. For example:
I'm not sure whether this is the main reason of the flake, but we haven't found any other possible reason yet. :) |
Ah...yeah...that jogged my memory. Thanks for the explanation. Deleting by UID would be great. |
This is not enough, the pod may be deleted and recreated after the check in kubelet and before the deletion request reaches the API server. We need to use #22965, which technically is still "deleting by Name", but you can set the UID as a precondition. |
Automatic merge from submit-queue Delete pod with uid as precondition. Addressed #25169 (comment). Fix #25169 Fix #24937 This PR change status manager to delete pods with uid as a precondition, so that kubelet won't delete pods with different uid but the same name and namespace accidentally. /cc @yujuhong
logs
The text was updated successfully, but these errors were encountered: