Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/update-codecgen.sh is creating codecs that fail verification #24473

Closed
derekwaynecarr opened this issue Apr 19, 2016 · 16 comments
Closed

hack/update-codecgen.sh is creating codecs that fail verification #24473

derekwaynecarr opened this issue Apr 19, 2016 · 16 comments
Assignees
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@derekwaynecarr
Copy link
Member

As an example, see the change in the following PR:

#24347 (comment)

/cc @kubernetes/rh-cluster-infra @kubernetes/sig-api-machinery

@lavalamp lavalamp added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 19, 2016
@wojtek-t
Copy link
Member

This is super strange - it's changing codecs for types that didn't change in that PR.

@wojtek-t
Copy link
Member

@derekwaynecarr - I'm not able to reproduce this issue.

When I ran hack/update-codecgen.sh at the changes from first commit of #24347 the only changes that were generated for me are those in pkg/api/v1/types.generated.go
Then running hack/verify-codecgen.sh works fine.

I have no idea how your changes from:
cmd/libs/go2idl/client-gen/testdata/apis/testgroup.k8s.io/types.generated.go
were generated.

@smarterclayton
Copy link
Contributor

smarterclayton commented Apr 20, 2016 via email

@wojtek-t
Copy link
Member

I'm using 1.6

@derekwaynecarr
Copy link
Member Author

I am using 1.6.

@derekwaynecarr
Copy link
Member Author

If I do the following:

$ go version
go version go1.6.1 linux/amd64
$ git fetch upstream
$ git checkout master
$ git rebase upstream/master
$ make clean
$ make all
$ hack/verify-codecgen.sh --> no error
$ hack/update-codecgen.sh
$ git status
[decarr@localhost kubernetes (master)]$ git status
On branch master
Your branch is ahead of 'origin/master' by 1382 commits.
  (use "git push" to publish your local commits)
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

    modified:   cmd/libs/go2idl/client-gen/testdata/apis/testgroup.k8s.io/types.generated.go

@derekwaynecarr
Copy link
Member Author

So even with no code change, the tool is trying to changing something.

@derekwaynecarr
Copy link
Member Author

Hmm, let me go back to go 1.6.0 and try that out... maybe there is a diff between go 1.6.0 and go 1.6.1

@derekwaynecarr
Copy link
Member Author

I switched to run go 1.6 and have the same problem.

$ go version
go version go1.6 linux/amd64

This is now blocking multiple PRs I need to get merged so if anyone else can assist its much appreciated.

@wojtek-t
Copy link
Member

That's super strange - I'm not able to reproduce this problem.

@wojtek-t
Copy link
Member

@derekwaynecarr - are you running this on mac? We used to have some problems in the past that it was working on linux, but wasn't working correctly on mac. However, I don't have mac, so I'm not able to debug it if that's the case.

@derekwaynecarr
Copy link
Member Author

No Mac, Linux Fedora 23

On Thursday, April 21, 2016, Wojciech Tyczynski notifications@github.com
wrote:

@derekwaynecarr https://github.com/derekwaynecarr - are you running
this on mac? We used to have some problems in the past that it was working
on linux, but wasn't working correctly on mac. However, I don't have mac,
so I'm not able to debug it if that's the case.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#24473 (comment)

@wojtek-t
Copy link
Member

Super strange.. the I don't know why I can't reproduce it.

@therc
Copy link
Member

therc commented Apr 27, 2016

Does it make a difference if you set GO15VENDOREXPERIMENT to 0? Yesterday I wasted a couple of hours on something like this and I tried so many things. I think #23749 has what fixed it for me.

@therc therc mentioned this issue Apr 27, 2016
3 tasks
@pmorie
Copy link
Member

pmorie commented Apr 28, 2016

For the record i have had this problem many times before. It eventually goes away, but it always comes back 👻

@wojtek-t
Copy link
Member

I think it was finally fixed by @thockin in #25240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

6 participants