Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression on apiserver CORS #24086

Closed
pendoragon opened this issue Apr 10, 2016 · 9 comments
Closed

regression on apiserver CORS #24086

pendoragon opened this issue Apr 10, 2016 · 9 comments
Assignees
@nikhiljindal
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@pendoragon
Copy link
Contributor

We found a regression on apiserver CORS that was previously fixed by #17093. It seems the regression is caused by #18113 during apiserver refactoring.
Related issue #16431.
@pendoragon
Copy link
Contributor Author

@nikhiljindal Is this intended or did I miss anything?

@lavalamp lavalamp added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 13, 2016
@lavalamp
Copy link
Member

Sorry about this, it probably got lost in a rebase. That said, the original PR should have included a test, and it's totally my fault for not requesting one.

@lavalamp lavalamp added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 13, 2016
@nikhiljindal
Copy link
Contributor

yes sorry it was not intentional.
Thanks for pointing it out. Will fix.

@nikhiljindal nikhiljindal self-assigned this Apr 13, 2016
@pendoragon
Copy link
Contributor Author

Good to know! Thanks!

@nikhiljindal nikhiljindal mentioned this issue Jun 14, 2016
Closed
@nikhiljindal
Copy link
Contributor

Sorry for sitting on this for so long.
I have a WIP PR here: #27386 which doesnt seem to be doing what it is supposed to do. I am still trying to figure out why.

@nikhiljindal
Copy link
Contributor

Ref #27076 (kubernetes 1.3 known issues)

@ddska ddska mentioned this issue Jul 1, 2016
Closed
@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhiljindal nikhiljindal

Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lavalamp @pendoragon @nikhiljindal @k8s-ci-robot @fejta-bot