Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubelet perf tests using the new metrics API #23961

Closed
dchen1107 opened this issue Apr 7, 2016 · 10 comments
Closed

Update kubelet perf tests using the new metrics API #23961

dchen1107 opened this issue Apr 7, 2016 · 10 comments
Assignees
Labels
area/test priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone

Comments

@dchen1107
Copy link
Member

Forked from #23956 (comment)

kubelet perf tests are using old stats apis. They need to be ported over to use the summary API. We should fix this.

cc/ @kubernetes/goog-node

@dchen1107 dchen1107 added area/test priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 7, 2016
@andyzheng0831
Copy link

cc/ @roberthbailey @fabioy @wonderfly, the 3 failed GKE e2e test cases in our Jenkins are all due to this issue.

@andyzheng0831
Copy link

@dchen1107 No assignee? And should we target this for milestone 1.2?

@yujuhong yujuhong self-assigned this Apr 7, 2016
@yujuhong
Copy link
Contributor

yujuhong commented Apr 7, 2016

I will work on it this week.

@dchen1107
Copy link
Member Author

No need to target for milestone 1.2. New Kubelet metrics API is still in alpha, and the old ones are not deprecated yet. Also this is a cleanup task, and it is not the root cause of your issue: #23956

@dchen1107
Copy link
Member Author

UPDATE: The test itself is hard-coded with docker's cgroup path. We should fix that as soon as possible.

@andyzheng0831
Copy link

The root cause is that cgroup "docker-daemon" is hard-coded in the kubelet_perf.go. But as #23956 (comment), this cgroup should not be created when systemd manages docker. Clean up this part should be enough for our testing.

@sjpotter
Copy link
Contributor

sjpotter commented Apr 7, 2016

this also impacts rktnetes, working around it by forcing it to think its not on gce/gke so it only uses / cgroup as don't have any other other static cgroups it is looking for, but in reality doesn't help much, just going to mark them as bad tests right now for us

@dchen1107
Copy link
Member Author

Ok, since we decided to have a patch release including #23996, we need to address this very test issue for 1.2 too. cc/ @roberthbailey

@yujuhong
Copy link
Contributor

yujuhong commented Apr 8, 2016

this also impacts rktnetes, working around it by forcing it to think its not on gce/gke so it only uses / cgroup as don't have any other other static cgroups it is looking for, but in reality doesn't help much, just going to mark them as bad tests right now for us

For rkt and other container runtimes, I'll upload a separate PR to not check the runtime stats at all. The PR base the decision on the container runtime type reported by the node status. Any objections? @sjpotter @derekwaynecarr

@yujuhong
Copy link
Contributor

#24003 was merged long ago. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

4 participants