Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/update-codecgen.sh not working #23749

Closed
goltermann opened this issue Apr 1, 2016 · 2 comments
Closed

hack/update-codecgen.sh not working #23749

goltermann opened this issue Apr 1, 2016 · 2 comments
Assignees
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@goltermann
Copy link
Contributor

I had a change where I needed to run this command. It appears to be generating the .tmp files just fine, but the mv "${base_generated_file}.tmp" "${base_generated_file}" must be silently failing. After the script is run, my folder has both a types.generated.go and types.generated.go.tmp. If I just do the mv myself, everything works, so the .tmp file has the right updates.

Also, while we're in there, the year 2015 is hardcoded. We should parse the output of "date" or something like that.

@saad-ali saad-ali added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 7, 2016
@lavalamp
Copy link
Member

@goltermann is this still happening to you?

@goltermann
Copy link
Contributor Author

I don't see it now, so I suspect it got fixed along the way. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

4 participants