-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Docker v1.11 #23397
Comments
xref #22765 - automate this process |
The really big change here is that you need four binaries instead of one: |
The salt script uses packages. So multiple binaries should not be an issue On Thu, Mar 24, 2016 at 10:31 AM, Lucas Käldström notifications@github.com
|
We may want to put both containerd and docker into one cgroup to account for the resource usage. |
kube-proxy fails to come up. From
|
runc by default mounts The privileged container will need to unmount it to write to it. I added it to the manifest and kube-proxy seems to be working after that. EDIT: I added |
Results from running e2e tests on v1.11.0-rc2:
Lots to look into here... |
FYI: RC4 is out - Linux 64bit tgz: https://test.docker.com/builds/Linux/x86_64/docker-1.11.0-rc4.tgz |
Blocker: google/cadvisor#1206 |
FYI, |
FYI, docker v1.11 is released |
By the way, this should was already fixed by moby/moby#21751 |
Almost all tests passing, yay! Remaining failures are:
3 of those are expected increases in memory usage (as described here). I think the other issue is just that my test cluster has insufficient disk quota (fails on master as well). EDIT: Those results are with updated cAdvisor & go-dockerclient godeps, which still need to be merged. |
Awesome!
Just wanted to double-check: Is containerd in the same cgroup with docker? If so, we can check the memory increase and bump the limits in the test accordingly. |
/cc @eparis - opinions? |
Performed manual restart tests, no issues found. Tested the following with no apparent issues:
|
v1.9 results copied from this comment Introduction Benchmark Environment
1. Benchmark list/inspect with varying number of containersUsing 2. Benchmark list/inspect with varying operation intervalsUsing
3. Benchmark list/inspect with varying number of goroutinesUsing
Conclusion |
If it helps, I remember the docker-containerd cpu usage to be quite low that it's insignificant. |
Yeah, that's consistent with my findings. I've updated the graphs to include containerd. |
Maybe the CPU spike is because docker processes request much faster than before, the benchmark sends more request in the same period. |
We might want to bump On Fri, May 20, 2016 at 2:38 PM, Yu-Ju Hong notifications@github.com
|
I was able to reproduce this on a container VM GCE instance, but not on an ubuntu trusty instance (that I installed docker v1.11 on using |
It's wried that docker micro benchmark #23397 (comment) didn't catch the error #23397 (comment). I think there are 2 possible reasons:
kubernetes-retired/contrib#581 will add error rate statistics. I'll run new docker micro benchmark with 1.11 again. |
@Random-Liu, 200 running containers won't hit this case. In addition to that, one needs to run the benchmark using a containerVM instance to hit this case (or it depends on the settings on your desktop). We should get your PR in to at least surface the errors when running the microbenchmark |
@Random-Liu and I talked about this last week, and we are extending the test suite for this. |
@dchen1107 ACK. Will increase the max container number in benchmark test. |
@timstclair #23397 (comment) is still unresolved AFAIK. |
Ah, I missed that. Thanks. |
Automatic merge from submit-queue Attempt 2: Bump GCE containerVM to container-v1-3-v20160517 (Docker 1.11.1) again. Workaround the issue of small root_maxkeys on the debian based container-vm image, and bump our image to the new alpha version for docker 1.11.1 validation. ref: #23397 #25893 cc/ @vishh @timstclair
Automatic merge from submit-queue Move containerd process into docker cgroup for versions >= v1.11 Addresses #23397 (comment) /cc @vishh @kubernetes/sig-node
Docker 1.11.2 is out: https://github.com/docker/docker/releases/tag/v1.11.2 Fixes that may be relevant:
|
@timstclair Is there anything left to do here? |
Nope, we've been defaulting to v1.11 on GCE / GKE since 1.3. |
Known issue of docker 1.11.X: #33882 (comment) by @mtaufen This is theorized to be the fix in Docker: moby/moby#25523 |
Docker v1.11 rcs are starting to show up. Its time to get started with the validation.
https://github.com/docker/docker/releases/tag/v1.11.0-rc1
cc @kubernetes/sig-node
EDIT(timstclair):
TASKS:
The text was updated successfully, but these errors were encountered: