Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decide on insecureSkipVerify setting when run against secured etcd #22858

Closed
adohe-zz opened this issue Mar 11, 2016 · 11 comments
Closed

decide on insecureSkipVerify setting when run against secured etcd #22858

adohe-zz opened this issue Mar 11, 2016 · 11 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@adohe-zz
Copy link

We just restore ability to run against secured etcd here #21535, but InsecureSkipTLSVerify is still questionable in secured etcd. We need to decide whether we should add this. @liggitt @timothysc @bgrant0607 @xiang90 ptal.

@bgrant0607
Copy link
Member

cc @lavalamp

@bgrant0607 bgrant0607 added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 11, 2016
@lavalamp
Copy link
Member

We're doing client cert to etcd, right? So I think it's OK, since etcd will be doing the cert checking, not apiserver. But maybe we can get confirmation from @xiang90.

@lavalamp lavalamp added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 11, 2016
@liggitt
Copy link
Member

liggitt commented Mar 14, 2016

This is about the client verifying the server's serving cert (2-way TLS), and whether the client has to have a way to disable that check.

@timothysc
Copy link
Member

/cc @hongchaodeng

@lavalamp
Copy link
Member

@liggitt you mean whether the client has a way to enable that check?

@liggitt
Copy link
Member

liggitt commented Mar 14, 2016

no... TLSInfo.ClientConfig() never returns a &tls.Config{} with InsecureSkipVerify set to true, so unless we do something to set it to true, the client will always verify the server TLS

@lavalamp
Copy link
Member

Oh, you're right. That changed since I saw it.

@lavalamp lavalamp added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 14, 2016
@lavalamp
Copy link
Member

I think admins can add their ca to the system list if they want to use self-signed certs for etcd.

Will raise priority again if I see a bunch of admins here complaining. :)

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Freeze the issue for 90d with /lifecycle frozen.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 15, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 14, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

7 participants