Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actors participating in leaderelection should annotate objects with a sequence number of the leadership #22007

Closed
mikedanese opened this issue Feb 25, 2016 · 7 comments
Closed

actors participating in leaderelection should annotate objects with a sequence number of the leadership #22007

mikedanese opened this issue Feb 25, 2016 · 7 comments
Labels
area/controller-manager area/HA lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.

Comments

@mikedanese
Copy link
Member

This allows actors to self validate their leadership over single objects.

We can implement a monotonically incrementing sequence number in the leader election record easily. Actors should annotate objects that they sync with this sequence number. Actors should not sync objects that have a sequence number greater then the actor's current sequence number.

This ensures that leader transition is atomic over single objects in the worst case, which is a guarantee we do not have today.

cc @bgrant0607 @davidopp @timothysc
@mikedanese mikedanese changed the title actors participating in leaderelection should annotate objects with their sequence number actors participating in leaderelection should annotate objects with a sequence number of the leadership Feb 25, 2016
@bgrant0607 bgrant0607 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/controller-manager area/HA sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. team/control-plane labels Feb 26, 2016
This was referenced Feb 26, 2016
Closed
Open
@timothysc
Copy link
Member

We can implement a monotonically incrementing sequence number in the leader election record easily.

This is very similar to http://zookeeper.apache.org/doc/trunk/recipes.html#sc_leaderElection use of sequence number.

@bgrant0607
Copy link
Member

cc @thockin @saad-ali @childsb

@timothysc
Copy link
Member

@mikedanese is there any reason we couldn't just use the objects ResourceVersion ?

@mikedanese
Copy link
Member Author

mikedanese commented Jul 29, 2016 •
edited
Loading

@timothysc resource version of what? can you describe a scheme?

@bgrant0607 bgrant0607 mentioned this issue Jul 9, 2023
Open
@bgrant0607 bgrant0607 mentioned this issue Nov 28, 2016
Open
@0xmichalis 0xmichalis mentioned this issue Nov 28, 2016
Merged
@caesarxuchao caesarxuchao mentioned this issue Mar 14, 2017
Merged
@fejta-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2017
@fejta-bot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2018
@bgrant0607
Copy link
Member

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 22, 2018
@thockin thockin closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller-manager area/HA lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@timothysc @mikedanese @thockin @bgrant0607 @k8s-ci-robot @fejta-bot