Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl --record should avoid capturing secrets on the command line #20508

Closed
janetkuo opened this issue Feb 2, 2016 · 9 comments
Closed

kubectl --record should avoid capturing secrets on the command line #20508

janetkuo opened this issue Feb 2, 2016 · 9 comments
Labels
area/kubectl area/security lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI.

Comments

@janetkuo
Copy link
Member

janetkuo commented Feb 2, 2016

Follow up #20035

#20035 (comment):

@smarterclayton: We need to be careful that security information does not get added to this annotation. I don't expect users would be surprised that --record records the command, but they would be surprised if we stored passwords or other attributes. (For example, --password, --token, possibly --username.)

@kubernetes/kubectl
@janetkuo janetkuo mentioned this issue Feb 2, 2016
Merged
@bgrant0607 bgrant0607 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 2, 2016
@liggitt
Copy link
Member

liggitt commented Feb 16, 2016

I think this is higher priority than p2, given the security implications

@liggitt liggitt mentioned this issue Feb 16, 2016
Merged
@bgrant0607 bgrant0607 mentioned this issue Apr 1, 2016
Closed
@bgrant0607 bgrant0607 mentioned this issue Aug 15, 2016
Closed
@mengqiy
Copy link
Member

mengqiy commented Oct 12, 2016

Any suggestions about how to fix this issue?

This was referenced Oct 13, 2016
Closed
Closed
@pwittrock pwittrock mentioned this issue Oct 20, 2016
Open
32 tasks
@soltysh soltysh mentioned this issue Jan 27, 2017
Open
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 15, 2017

/sig cli

@k8s-ci-robot k8s-ci-robot added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Jun 15, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 15, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 28, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 27, 2018
@mengqiy
Copy link
Member

mengqiy commented Jan 27, 2018

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 27, 2018
@pacoxu
Copy link
Member

pacoxu commented Sep 16, 2021

--record started to be deprecated in 1.22 since #102873.
We may close this one. Discussions in #40422.

@soltysh
Copy link
Contributor

soltysh commented Nov 3, 2021

/close

@k8s-ci-robot
Copy link
Contributor

@soltysh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubectl area/security lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/cli Categorizes an issue or PR as relevant to SIG CLI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests