Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty up cluster scripts #20

Closed
jbeda opened this issue Jun 8, 2014 · 1 comment
Closed

Pretty up cluster scripts #20

jbeda opened this issue Jun 8, 2014 · 1 comment
Labels
area/cloudprovider area/platform/gce priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Comments

@jbeda
Copy link
Contributor

jbeda commented Jun 8, 2014

Right now the cluster scripts just call 'gcloud compute' and pass on the yaml output of those commands verbatim. This is really verbose and ugly.

Instead, we should probably do something like save those to /tmp and delete them if there are no errors. We want the output of the operations around in case there are errors but there is no need to spam the console.

pmorie referenced this issue in pmorie/kubernetes Aug 8, 2014
@bgrant0607 bgrant0607 added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Dec 3, 2014
@bgrant0607 bgrant0607 added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 28, 2015
@davidopp davidopp added team/control-plane area/cloudprovider and removed sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Aug 23, 2015
feiskyer added a commit to feiskyer/kubernetes that referenced this issue Oct 25, 2015
dlorenc added a commit to dlorenc/kubernetes that referenced this issue May 13, 2016
@mikedanese
Copy link
Member

I think this has been superceded.

lazypower pushed a commit to lazypower/kubernetes that referenced this issue Sep 20, 2016
joshwget pushed a commit to joshwget/kubernetes that referenced this issue Sep 20, 2016
add host network ip address to cache
dagnello added a commit to dagnello/kubernetes that referenced this issue Oct 7, 2016
Corect filtering of OpenStack LBaaS resources to delete
xingzhou pushed a commit to xingzhou/kubernetes that referenced this issue Dec 15, 2016
andyzhangx added a commit to andyzhangx/kubernetes that referenced this issue Oct 26, 2017
JiangtianLi pushed a commit to JiangtianLi/kubernetes that referenced this issue Nov 29, 2017
andyzhangx added a commit to andyzhangx/kubernetes that referenced this issue May 16, 2018
tossmilestone added a commit to tossmilestone/kubernetes that referenced this issue Aug 10, 2018
HandleError include the type of the error object
yujuhong added a commit to yujuhong/kubernetes that referenced this issue Nov 17, 2018
Get docker logs from windows nodes
seans3 pushed a commit to seans3/kubernetes that referenced this issue Apr 10, 2019
varunmar pushed a commit to varunmar/kubernetes that referenced this issue Apr 26, 2019
make: add condition to use docker run -t flag
cjcullen pushed a commit to cjcullen/kubernetes that referenced this issue Apr 27, 2019
Update a few more PSC member references
yangkev added a commit to yangkev/kubernetes that referenced this issue Apr 9, 2020
This introduces the following metrics:

    cronjob_controller_sync_one_wall_time_gauge_seconds
    cronjob_controller_sync_one_wall_time_histogram_seconds
    cronjob_controller_sync_all_wall_time_gauge_seconds
    cronjob_controller_sync_all_wall_time_histogram_seconds

For measuring performance of the sync controller loops.

For cronjob_controller_sync_all_wall_time_histogram_seconds, this tends to range between 10-30 seconds depending on rate limit settings. I chose linear buckets from 1-60
seconds to get enough granularity.

For cronjob_controller_sync_one_wall_time_histogram_seconds, this tends to fluctuate exponentially directly proportional to kubeclient rate limiting, so that's why I chose exponential
buckets from 1 microsecond to 1 second.

Implementation note: rate limit saturation isn't actually measured despite the code living in the codebase (https://github.com/lyft/kubernetes/blob/f678a63e9a17580b35805021fe4112f0f4cd6271/pkg/util/metrics/util.go#L68-L74).  Measuring rate limit saturation would help us determine why the CronJobController is slow. Since that's not available, the next best thing is syncOne wall time.
b3atlesfan pushed a commit to b3atlesfan/kubernetes that referenced this issue Feb 5, 2021
add support ip masquerade of non-overlay addresses; cleanup
ncdc pushed a commit to ncdc/kubernetes that referenced this issue Dec 1, 2021
…panic

Additional checks to avoid panic due to a non-existant CRD.
linxiulei pushed a commit to linxiulei/kubernetes that referenced this issue Jan 18, 2024
thockin added a commit to thockin/kubernetes that referenced this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloudprovider area/platform/gce priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

No branches or pull requests

4 participants