Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make clean shouldn't require Docker if Docker is not installed #1959

Closed
smarterclayton opened this issue Oct 22, 2014 · 1 comment · Fixed by #3252
Closed

make clean shouldn't require Docker if Docker is not installed #1959

smarterclayton opened this issue Oct 22, 2014 · 1 comment · Fixed by #3252
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@smarterclayton
Copy link
Contributor

Use case: running hack/build-go.sh and make clean on a Mac without docker fails because it's assuming Docker is required.

Would prefer if make clean bypassed image path if Docker is not installed
@smarterclayton smarterclayton added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 22, 2014
@thockin
Copy link
Member

thockin commented Oct 23, 2014

Yeah, Joe, could we have make clean and make veryclean or somethign?

On Wed, Oct 22, 2014 at 9:36 AM, Clayton Coleman notifications@github.com
wrote:

Use case: running hack/build-go.sh and make clean on a Mac without docker
fails because it's assuming Docker is required.

Would prefer if make clean bypassed image path if Docker is not installed

Reply to this email directly or view it on GitHub
#1959.

jbeda added a commit to jbeda/kubernetes that referenced this issue Jan 6, 2015
@jbeda
Make 'make clean' work with Docker not installed.
4b94829 
Fixes kubernetes#1959.
@jbeda jbeda mentioned this issue Jan 6, 2015
Merged
@sidharta-s sidharta-s mentioned this issue Feb 20, 2015
Closed
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this issue May 10, 2024
@openshift-merge-bot
Merge pull request kubernetes#1959 from cblecker/e2e-fix
681e46b 
API-1809: Provide SCC access via RBAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make 'make clean' work with Docker not installed. jbeda/kubernetes
3 participants
@jbeda @smarterclayton @thockin