Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/release.sh script complains docker container name already assigned #1853

Closed
tsvenkat opened this issue Oct 17, 2014 · 4 comments · Fixed by #2780
Closed

build/release.sh script complains docker container name already assigned #1853

tsvenkat opened this issue Oct 17, 2014 · 4 comments · Fixed by #2780

Comments

@tsvenkat
Copy link

When running build/release.sh, the kube::build::run_build_command removes any left over container from previous run, runs the container and then removes the container.
On faster systems, there could be a timing issue after the container has done running and the "docker rm" is done. This would cause the container not to be removed properly and create trouble building the container for the next arch.

I was able to fix this by introducing a "sleep 1" statement before the second "docker rm". There is a comment that says the ideal way is to use the "--rm" flag of docker run, but it is not done due to some known issue. Until that is resolved, if somebody runs into this issue, please try this workaround.

@jbeda jbeda self-assigned this Oct 17, 2014
@jbeda
Copy link
Contributor

jbeda commented Oct 17, 2014

I've seen this happen but I thought I squashed it. One case that confused this stuff is if you are running non-interactive.

An idea here is to:

  • run with --rm
  • pick semi-unique names for containers so that we don't get this conflict
  • fix up make-clean to clean up containers that match the name pattern

I'm actually not hitting this at all right now so any detail of how and where might help us find a better way to work around this.

@jbeda
Copy link
Contributor

jbeda commented Nov 17, 2014

I haven't seen this in quite a while. I'm going to close this. If you (or anyone else) starts seeing this again let me know and we can look at taking action.

@jbeda jbeda closed this as completed Nov 17, 2014
@zmerlynn
Copy link
Member

zmerlynn commented Dec 6, 2014

I hit this pretty consistently with "make release" on a fresh clone on my desktop. I'll send a PR later today (baby duty calls).

zmerlynn added a commit to zmerlynn/kubernetes that referenced this issue Dec 6, 2014
@jbeda jbeda reopened this Dec 8, 2014
@jbeda
Copy link
Contributor

jbeda commented Dec 8, 2014

Closed with #2780

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants