Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate dependency on tools.EtcdClient from contrib/mesos/pkg #18153

Closed
wojtek-t opened this issue Dec 3, 2015 · 4 comments
Closed

Eliminate dependency on tools.EtcdClient from contrib/mesos/pkg #18153

wojtek-t opened this issue Dec 3, 2015 · 4 comments
Labels
area/platform/mesos kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@wojtek-t
Copy link
Member

wojtek-t commented Dec 3, 2015

Context: We're going to completely get rid of "tools.EtcdClient" interface.
Instead, we wish everyone to use storage.Interface.

Mesos code is the biggest (non-trivial) remaining part of dependency on "tools.EtcdClient" - the following files depend on it:

contrib/mesos/pkg/election/etcd_master.go
contrib/mesos/pkg/election/etcd_master_test.go
contrib/mesos/pkg/scheduler/service/service.go

@sttts @karlkfi @timothysc
@wojtek-t wojtek-t added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. area/platform/mesos team/mesosphere labels Dec 3, 2015
@sttts
Copy link
Contributor

sttts commented Dec 3, 2015

@wojtek-t we will discuss internally how to get rid of that dependency soon. We don't like this the current situation to access the etcd in parallel to the apiserver either.

@sttts sttts mentioned this issue Dec 3, 2015
Closed
2 tasks
@timothysc timothysc mentioned this issue Dec 3, 2015
Merged
@lavalamp
Copy link
Member

lavalamp commented Dec 3, 2015

Maybe temporarily we can just move that code under the mesos/ directory?

@jdef jdef mentioned this issue Jan 12, 2016
Merged
@jdef
Copy link
Contributor

jdef commented Jan 12, 2016

this appears to have been resolved by #18635. granted, the mesos code is still storing things in etcd using the "keys API" but at least there no longer a dependency on tools.EtcdClient

@timothysc
Copy link
Member

yup, @lavalamp please close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/platform/mesos kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@timothysc @lavalamp @sttts @jdef @wojtek-t