Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The addNode and UpdateNode methods in pkg/controller/daemon/controller.go should only enqueue related DaemonSet #17441

Closed
WeixuZhuang opened this issue Nov 18, 2015 · 1 comment
Closed

The addNode and UpdateNode methods in pkg/controller/daemon/controller.go should only enqueue related DaemonSet #17441

WeixuZhuang opened this issue Nov 18, 2015 · 1 comment
Labels
area/controller-manager area/workload-api/daemonset priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@WeixuZhuang
Copy link
Contributor

When add node or update node func is called, all DaemonSets are enqueued to workqueue of DaemonSet Controller. The consumer of the workqueue does an iteration of node.List for every DaemonSet in the workqueue.

It is not efficient, we should enqueue DaemonSet only it has new or updated nodes in it.
@WeixuZhuang WeixuZhuang mentioned this issue Nov 18, 2015
Merged
@davidopp davidopp added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Nov 26, 2015
@bgrant0607 bgrant0607 added area/workload-api/daemonset sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed team/control-plane (deprecated - do not use) labels Mar 21, 2017
@bgrant0607 bgrant0607 mentioned this issue Mar 21, 2017
Closed
@0xmichalis
Copy link
Contributor

This is fixed, the DS controller is enqueueing only the DSs it has to on every node ADD/UPDATE event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller-manager area/workload-api/daemonset priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@0xmichalis @bgrant0607 @davidopp @mwielgus @WeixuZhuang