Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support entrypoint #1710

Closed
proppy opened this issue Oct 10, 2014 · 8 comments
Closed

Support entrypoint #1710

proppy opened this issue Oct 10, 2014 · 8 comments
Labels
area/api Indicates an issue on api area. area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@proppy
Copy link
Contributor

proppy commented Oct 10, 2014

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/types.go#L222 doesn't seem to allow it.

@thockin
Copy link
Member

thockin commented Oct 10, 2014

Yeah. Interesting. I get what they are doing with entrypoint vs command,
but it's sort of horribly inconsistent from an end-user POV. For some
containers you have to specify command, but not argv[0], for others you
have to specify a full command with argv.

Is there a common mode we can fall back on? Something like:

if len(container.command) > 0 {
endpoint = container.command[0]
container.command = container.command[1:]
}

I guess that breaks for anyone that relies on entrypoint and adds args to
it.

Uggh. So tacky. Can't we do better?

On Thu, Oct 9, 2014 at 5:17 PM, Johan Euphrosine notifications@github.com
wrote:

https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/types.go#L222
doesn't seem to allow it.

Reply to this email directly or view it on GitHub
#1710.

@bgrant0607 bgrant0607 added area/api Indicates an issue on api area. area/kubelet-api labels Oct 10, 2014
@bgrant0607
Copy link
Member

@proppy OOC, what do you want to do that requires overriding the entrypoint of the container?

@thockin In this area, we might as well match Docker's API, IMO.

@proppy
Copy link
Contributor Author

proppy commented Oct 10, 2014

@bgrant0607 can't really say, that's part of the docker primitive that users can manipulate. Some docker image might expose an entrypoint that you want to override, i.e: add flags to an interpreter or prefix with a debugger.

@bgrant0607
Copy link
Member

Can't flags be added without exposing entrypoint?

Common Docker cases like starting a shell or debugger won't even work right now, since we don't have a way to open stdin (#1521).

@proppy
Copy link
Contributor Author

proppy commented Oct 10, 2014

It depends, flags could be added w/ CMD (which is passed to ENTRYPOINT argv if defined) but it means you have to override the default args that might be embedded in the image metadata.

@thockin
Copy link
Member

thockin commented Oct 10, 2014

Docker's API is a mess here, but given that and given that people USE
Docker's messy API, I think we're stuck.

On Fri, Oct 10, 2014 at 10:41 AM, bgrant0607 notifications@github.com
wrote:

@proppy https://github.com/proppy OOC, what do you want to do that
requires overriding the entrypoint of the container?

@thockin https://github.com/thockin In this area, we might as well
match Docker's API, IMO.

Reply to this email directly or view it on GitHub
#1710 (comment)
.

@bgrant0607 bgrant0607 added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Dec 4, 2014
@bgrant0607 bgrant0607 changed the title add entrypoint to containerManifest Support entrypoint Dec 10, 2014
@bgrant0607 bgrant0607 added area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. and removed area/kubelet-api priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Dec 10, 2014
@bgrant0607
Copy link
Member

/cc @erictune

@bgrant0607
Copy link
Member

Closing in favor of #2316, where all the discussion is happening.

@dchen1107 dchen1107 added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/kubelet priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

4 participants