Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out release infra from build infra #16529

Closed
5 tasks done
ikehz opened this issue Oct 29, 2015 · 4 comments
Closed
5 tasks done

Separate out release infra from build infra #16529

ikehz opened this issue Oct 29, 2015 · 4 comments
Assignees
@ixdy @david-mcmahon
Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ikehz
Copy link
Contributor

ikehz commented Oct 29, 2015 •
edited by david-mcmahon
Loading

To avoid this kind of thing: #16521. This was an issue in which our test/release infra needed to change, and we had to cherrypick a bunch of stuff back into the release-1.0 branch, because we rely on release infra inside that branch.

Instead, we should have separate release infra (probably in contrib) that drives the release process, and relies on a clearly-defined interface with the build infra, (e.g. run make release, and expect all artifacts to exist in _output).

Specific action items:

  • Define a clear contract between build and release
    • Straw man proposal: build logic is invoked with a single command, (i.e. make release or something similar,) and promises to put all artifacts for release into a specific local directory that the releasing logic can then push
  • Factor out all kube::release::... logic from build/common.sh, and move all push-... scripts to release/
    • We might want to move all of the releasing infrastructure to kubernetes/contrib, but that opens up issues of how to deploy to a cluster (see next item)
  • Figure out how to handle pushing to GCS from the build logic (for deployment) and how that can play nice with our releasing logic (cc @mikedanese regarding your work on deployment)
  • Figure out what to do with build/release.sh
  • Factor out versioning logic from push-... scripts, cut-official-release.sh, and build-official-release.sh
@ikehz ikehz added the area/release-eng Issues or PRs related to the Release Engineering subproject label Oct 29, 2015
@ikehz ikehz mentioned this issue Oct 29, 2015
Closed
@ikehz ikehz self-assigned this Oct 29, 2015
@ikehz ikehz mentioned this issue Oct 29, 2015
Merged
@ikehz ikehz added priority/backlog Higher priority than priority/awaiting-more-evidence. area/build-release labels Oct 30, 2015
@ikehz
Copy link
Contributor Author

ikehz commented Nov 4, 2015

#16787 is another example of the kind of thing we want to avoid.

@ikehz ikehz added this to the v1.2-candidate milestone Nov 4, 2015
@ikehz ikehz assigned ikehz and unassigned ikehz Nov 5, 2015
@ikehz
Copy link
Contributor Author

ikehz commented Nov 6, 2015

Relatedly, we should seriously refactor the way we do uploading and version comparison in build/common.sh, (what may become release/common.sh).

@ikehz ikehz mentioned this issue Nov 6, 2015
Merged
@ikehz
Copy link
Contributor Author

ikehz commented Nov 6, 2015

#16919 another example.

@ikehz ikehz mentioned this issue Nov 6, 2015
Closed
@mikedanese
Copy link
Member

Figure out how to handle pushing to GCS from the build logic (for deployment) and how that can play nice with our releasing logic (cc @mikedanese regarding your work on deployment)

This is #8686 and it's super painful right now.

@ikehz ikehz mentioned this issue Nov 6, 2015
Closed
13 tasks
@david-mcmahon david-mcmahon assigned david-mcmahon and unassigned ikehz Jan 6, 2016
@david-mcmahon david-mcmahon removed this from the v1.2-candidate milestone Feb 18, 2016
@david-mcmahon david-mcmahon added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 6, 2016
@david-mcmahon david-mcmahon mentioned this issue Apr 6, 2016
Closed
@david-mcmahon david-mcmahon mentioned this issue Jun 10, 2016
Merged
This was referenced Jul 8, 2016
Merged
Merged
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 15, 2016
Merge pull request #28922 from david-mcmahon/release-push
4030afd 
Automatic merge from submit-queue

Add RELEASE_INFRA_PUSH related code to support pushes from kubernetes/release.

ref #16529
@david-mcmahon david-mcmahon mentioned this issue Aug 15, 2016
Closed
@ixdy ixdy self-assigned this Sep 7, 2016
k8s-github-robot pushed a commit that referenced this issue Sep 10, 2016
Merge pull request #24629 from david-mcmahon/release-deprecation
da4f0ca 
Automatic merge from submit-queue

Deprecate release infrastructure and doc - moved to kubernetes/release

Part 2 of kubernetes/release#1
This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release.

ref #16529
xingzhou pushed a commit to xingzhou/kubernetes that referenced this issue Dec 15, 2016
Merge pull request kubernetes#24629 from david-mcmahon/release-deprec…
f78c492 
…ation

Automatic merge from submit-queue

Deprecate release infrastructure and doc - moved to kubernetes/release

Part 2 of kubernetes/release#1
This PR finalizes the split between the main kubernetes repo and the release tooling now under kubernetes/release.

ref kubernetes#16529
@justaugustus justaugustus mentioned this issue Jul 4, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ixdy ixdy

@david-mcmahon david-mcmahon

Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ikehz @mikedanese @ixdy @david-mcmahon