-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetReference shouldn't hardcode api prefix #1490
Comments
Being able to prefix the apiserver with a path is useful to some folks. The tradeoff being that general url generation gets much more difficult. In addition, in the real world URLs tend to drift (hosts, paths) so persisting "real urls" requires a fair amount of planning for the future to allow migrations. The primary use case for prefixing the base path is to run two installations on the same server, or to fit into a root domain (mycompany.com/kubernetes/api) that has an existing proxy or load balancing infrastructure, or because the chosen prefix "api" is not preferred.
|
I think that regexp is compatible with prefixes, no? Does it need to change? |
Our prefix is /osapi/, which is think triggered this |
Oh, well, that's unfortunate. Hrm. |
We definitely shouldn't hardcode the api prefix here. Isn't there a better way than parsing selfLink? Or maybe we should just represent object references using relative URLs? |
I think this is prerequisite for #2098. |
I dont see https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/api/ref.go using that regex anymore. It is extracting the version from ObjectReference. |
OCPBUGS-7267: add SeccompProfile to Pod and Container accessors/mutators
#1475 assumes there is a fixed path prefixes in the apiserver and client, so that it can retrieve version like this:
But above assumption is not valid today, we should do something to enforce such assumption, or find another way to retrieve version.
@smarterclayton
The text was updated successfully, but these errors were encountered: