Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swap Feature] Investigate what happens if a cluster has some swap enabled nodes and others that are not enabled. #122279

Closed
Tracked by #2400
kannon92 opened this issue Dec 12, 2023 · 5 comments
Closed
Tracked by #2400

[Swap Feature] Investigate what happens if a cluster has some swap enabled nodes and others that are not enabled. #122279

kannon92 opened this issue Dec 12, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@kannon92
Copy link
Contributor

What would you like to be added?

In GA of swap, our goal would be that users/admins can enable swap for their nodes. It could be possible to have a heterogenous cluster where some nodes have swap enabled and others do not.

If a user submits a burstable workload with LimitedSwap, then we would expect swap to be used if feature is on. But if the node does not have swap enabled, then this would not be enabled.

Why is this needed?

This could cause problems with scheduling.

We should investigate and see if there is ways to control this on a heterogeneous cluster.
@kannon92 kannon92 added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 12, 2023
@kannon92
Copy link
Contributor Author

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 12, 2023
@kannon92 kannon92 mentioned this issue Dec 12, 2023
Open
60 tasks
@kannon92
Copy link
Contributor Author

One thing we can do is solve issues like this is to have nodes that have swap enabled should have a taint added.

This could be a taint we add to nodes if swap is detected.

So that way a user could ask for a swap node in the scheduler.

@kannon92
Copy link
Contributor Author

kannon92 commented Mar 6, 2024

I added a NFD issue.

kubernetes-sigs/node-feature-discovery#1584.

This is all about labels for swap so we figured one way could be to use NFD to detect if your node has swap enabled. And then add a label for that.

/close

@k8s-ci-robot
Copy link
Contributor

@kannon92: Closing this issue.

In response to this:

I added a NFD issue.

kubernetes-sigs/node-feature-discovery#1584.

This is all about labels for swap so we figured one way could be to use NFD to detect if your node has swap enabled. And then add a label for that.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kannon92 @k8s-ci-robot