Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow framework plugins to be closed #118147

Closed
codefromthecrypt opened this issue May 20, 2023 · 6 comments · Fixed by #122498
Closed

Allow framework plugins to be closed #118147

codefromthecrypt opened this issue May 20, 2023 · 6 comments · Fixed by #122498
Assignees
@Gekko0114
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@codefromthecrypt
Copy link
Contributor

What would you like to be added?

I would like framework.Plugin implementations, specifically scheduler plugins to be when the scheduler is being stopped. It could implement this by a type assertion on io.Closer, so that old schedulers don't have to implement it.

Why is this needed?

For example, wasm plugins internally use mapped memory and it would be good to cleanly unmap them.

Without this we could use finalizers, but doing that has problems including some overhead.
@codefromthecrypt codefromthecrypt added the kind/feature Categorizes issue or PR as related to a new feature. label May 20, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 20, 2023
@sanposhiho
Copy link
Member

/sig scheduling

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 20, 2023
@sanposhiho
Copy link
Member

/assign

@kerthcet
Copy link
Member

@codefromthecrypt do you have any examples for this?

@codefromthecrypt
Copy link
Contributor Author

@kerthcet yep. The wasm runtime wazero internally has a compilation code cache which includes mmapped modules. https://github.com/kubernetes-sigs/kube-scheduler-wasm-extension/pull/6/files#diff-1bdb059cf97778a163c3746f2f5a0d27cf6f1d114652a534db91b810173624bcR132-R138

@codefromthecrypt codefromthecrypt mentioned this issue Jun 12, 2023
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Scheduling Sep 22, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Sep 29, 2023
@helayoty helayoty removed this from SIG Apps Sep 29, 2023
@sanposhiho
Copy link
Member

/unassign
/assign @Gekko0114

@k8s-ci-robot k8s-ci-robot assigned Gekko0114 and unassigned sanposhiho Dec 18, 2023
@Gekko0114 Gekko0114 mentioned this issue Dec 27, 2023
Merged
@sanposhiho
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 28, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Scheduling Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gekko0114 Gekko0114

Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow framework plugins to be closed Gekko0114/kubernetes
5 participants
@codefromthecrypt @kerthcet @k8s-ci-robot @Gekko0114 @sanposhiho