Open
Description
What would you like to be added?
Following up from this discussion - #116420 (comment)
There are different components that fall in the critical path for the k8s API today (apiserver (core), authn/authz webhooks, mutating/validating/conversion webhooks, etcd, extension apiservers - maybe more I'm missing). While some of those do, bunch of them don't seem to have metrics tracking request/error counts and latency metrics. Here's what I found so far (will update as we learn more):
- Authentication webhook
- Authorization webhook
- Admission webhooks (mutating/validating)
- CRD Conversion webhook
- Etcd
- Extension apiserver
- request/error countsrequest latencies
Finally, wrt the apiserver itself, we measure request/error counts and these flavors of latency metrics today:
- e2e latency (capturing customer experience)SLI-based latency (measuring cloud-provider QoS)
We discussed adding a third flavor of latency metrics that measures only the apiserver "core" latency (not including any external callback/webhook mechanisms) here.
We don't have consensus that benefits of doing so outweigh the additional metric churn. We can revisit later as TBD
Why is this needed?
Metrics at component/dependency level allow us to:
- track each component's performance in isolation
- set internal (non-customer-facing) SLOs for teams owning those components
- narrow down the root-cause for API errors/latencies easily
/sig api-machinery
/sig auth
/sig scalability
/kind feature
/help
Metadata
Metadata
Labels
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Categorizes issue or PR as related to a new feature.Categorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG Auth.Categorizes an issue or PR as relevant to SIG Instrumentation.Categorizes an issue or PR as relevant to SIG Scalability.Indicates an issue or PR is ready to be actively worked on.
Type
Projects
Status
In Progress
Activity
k8s-ci-robot commentedon Apr 8, 2023
@shyamjvs:
This request has been marked as needing help from a contributor.
Guidelines
Please ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the
/remove-help
command.In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
shyamjvs commentedon Apr 8, 2023
cc @wojtek-t @lavalamp
Also please correct me if I misread any of the code.
HirazawaUi commentedon Apr 8, 2023
/assign
I think I can modify the
Authorization webhook
sectionmy-git9 commentedon Apr 8, 2023
/assign
I want work for
CRD Conversion webhook
section54 remaining items