Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KEP-2400] Add the ability to set a system-reserved quantity of swap on a node #105019

Closed
Tracked by #4128
ehashman opened this issue Sep 14, 2021 · 23 comments
Closed
Tracked by #4128

[KEP-2400] Add the ability to set a system-reserved quantity of swap on a node #105019

ehashman opened this issue Sep 14, 2021 · 23 comments
Assignees
@pacoxu
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ehashman
Copy link
Member

What would you like to be added:

Add the ability to set a system-reserved quantity of swap on a node.

  • KubeletConfiguration/kubelet CLI flag changes to specify quantity
  • Code updates
  • e2e tests

This should be a single PR.

Why is this needed:

See https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2400-node-swap#beta
@ehashman ehashman added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@ehashman ehashman mentioned this issue Sep 14, 2021
Open
60 tasks
@ehashman
Copy link
Member Author

/sig node
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 14, 2021
@ehashman
Copy link
Member Author

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Sep 14, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 15, 2021

I will work on it if my other tasks are not urgent. (I would like to be a backup.)

@pacoxu
Copy link
Member

pacoxu commented Sep 17, 2021

/assign

@pacoxu pacoxu mentioned this issue Sep 27, 2021
Closed
@pacoxu
Copy link
Member

pacoxu commented Oct 19, 2021

/assign @jonyhy96

I will be on vacation in the next two weeks. @jonyhy96 may help in the #105271 or open a new PR if needed. Thanks.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: GitHub didn't allow me to assign the following users: jonyhy96.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jonyhy96

I will be on vacation in the next two weeks. @jonyhy96 may help in the #105271 or open a new PR if needed. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2022
@ehashman
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2022
@ehashman
Copy link
Member Author

/milestone v1.24

@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 18, 2022
@ritpanjw
Copy link

Hi 👋 . Checking in from bug triage for 1.24, there is no activity on this PR from last 2-3 weeks, Should we be tracking progress on this issue for 1.24 release?

@pacoxu
Copy link
Member

pacoxu commented Mar 15, 2022

We are waiting on tests to be fixed before we merge the PR. It may have a little risk since the code freeze will come in two weeks.

@ritpanjw
Copy link

@pacoxu Hi 👋 Im checking in from bug triage team for release 1.24, we are very near to code freeze, would we be able to pull this in since you mentioned there is a little risk ?

@ehashman
Copy link
Member Author

/milestone clear
per kubernetes/enhancements#2400 (comment)

@k8s-ci-robot k8s-ci-robot removed this from the v1.24 milestone Mar 28, 2022
@pacoxu
Copy link
Member

pacoxu commented May 10, 2022 •
edited
Loading

https://docs.google.com/document/d/1Ne57gvidMEWXR70OxxnRkYquAoMpt56o75oZtg-OeBg/edit?disco=AAAAYK_tKPA

This one wasn't meant to be graduated before we get more feedback from users.

  • more user feedback are needed
  • more tests are needed
  • todo list needs to be completed

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2022
@pacoxu
Copy link
Member

pacoxu commented Sep 13, 2022

/remove-lifecycle stale
pr is waiting for reviewing.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 11, 2023
@pacoxu
Copy link
Member

pacoxu commented Jan 11, 2023

/remove-lifecycle rotten
PR is still waiting for review.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 11, 2023
@k8s-triage-robot
Copy link

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged.
Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Deprioritize it with /priority important-longterm or /priority backlog
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 25, 2023
@iholder101 iholder101 mentioned this issue Jul 19, 2023
Closed
35 tasks
@pacoxu
Copy link
Member

pacoxu commented Jul 26, 2023 •
edited
Loading

/triage accepted
#105271 is still in review for this. We have to wait for v1.29.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2023
@iholder101
Copy link
Contributor

This issue is old, outdated and inactive. Also, I don't have the rights to update the description and @ehashman is no longer working on this.

Closing in favor of this replacement issue: #120802.
/close

@k8s-ci-robot
Copy link
Contributor

@iholder101: Closing this issue.

In response to this:

This issue is old, outdated and inactive. Also, I don't have the rights to update the description and @ehashman is no longer working on this.

Closing in favor of this replacement issue: #120802.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pacoxu pacoxu

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Node Swap Beta
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add --system-reserved support for swap(cgroup v2 only): only for burstable pods pacoxu/kubernetes
7 participants
@pacoxu @ehashman @k8s-ci-robot @ritpanjw @k8s-triage-robot @iholder101 and others