Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string slice flag is not assigned #102621

Closed
vazmin opened this issue Jun 5, 2021 · 5 comments · Fixed by #102623
Closed

string slice flag is not assigned #102621

vazmin opened this issue Jun 5, 2021 · 5 comments · Fixed by #102623
Assignees
@jpbetz
Labels
area/provider/gcp Issues or PRs related to gcp provider area/test kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@vazmin
Copy link
Contributor

vazmin commented Jun 5, 2021

What happened:

flags.Var(cliflag.NewStringSlice(&cloudConfig.Zones), "gce-zones", "") , &cloudConfig.Zones is not assigned

What you expected to happen:

&cloudConfig.Zones is assigned

How to reproduce it (as minimally and precisely as possible):

Use cliflag.NewStringSlice to parse the command line parameters

Anything else we need to know?:

I am preparing to merge pr to solve this problem

Environment:

  • Kubernetes version (use kubectl version): N/A
  • Cloud provider or hardware configuration: N/A
  • OS (e.g: cat /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Install tools: N/A
  • Network plugin and version (if this is a network-related bug): N/A
  • Others: N/A
@vazmin vazmin added the kind/bug Categorizes issue or PR as related to a bug. label Jun 5, 2021
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 5, 2021
@vazmin vazmin mentioned this issue Jun 5, 2021
Merged
@neolit123
Copy link
Member

/sig cloud-provider
/area provider/gcp

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. area/provider/gcp Issues or PRs related to gcp provider and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2021
@neolit123
Copy link
Member

/area test

@stewart-yu
Copy link
Contributor

how about 'flags.VarP('？

@vazmin
Copy link
Contributor Author

vazmin commented Jun 15, 2021

how about 'flags.VarP('？

The pointer of StringSlice's values is assigned to the new address, and the relationship with the input parameter is broken. The 'flags.VarP(' also to no avail

@cheftako
Copy link
Member

/assign @jpbetz
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpbetz jpbetz

Labels
area/provider/gcp Issues or PRs related to gcp provider area/test kind/bug Categorizes issue or PR as related to a bug. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix bug where string slice flag is not assigned vazmin/kubernetes
6 participants
@neolit123 @jpbetz @cheftako @vazmin @k8s-ci-robot @stewart-yu