Skip to content

Commit

Permalink
Remove kubernetes metadata plugin
Browse files Browse the repository at this point in the history
  • Loading branch information
aledbf committed Aug 23, 2016
1 parent 5753a31 commit e2c5015
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# Please see http://docs.fluentd.org/articles/install-by-deb for more
# information about installing fluentd using deb package.

FROM gcr.io/google_containers/ubuntu-slim:0.3
FROM gcr.io/google_containers/ubuntu-slim:0.4
MAINTAINER Alex Robinson "arob@google.com"
MAINTAINER Jimmi Dyson "jimmidyson@gmail.com"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

# Copyright 2016 The Kubernetes Authors All rights reserved.
# Copyright 2015 The Kubernetes Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -29,7 +29,9 @@ apt-get install -y -q --no-install-recommends \
sed -i -e "s/USER=td-agent/USER=root/" -e "s/GROUP=td-agent/GROUP=root/" /etc/init.d/td-agent

# Install the Elasticsearch Fluentd plug-in.
td-agent-gem install fluent-plugin-kubernetes_metadata_filter fluent-plugin-elasticsearch
# http://docs.fluentd.org/articles/plugin-management
td-agent-gem install --no-document fluent-plugin-kubernetes_metadata_filter -v 0.24.0
td-agent-gem install --no-document fluent-plugin-elasticsearch -v 1.5.0

# Remove docs and postgres references
rm -rf /opt/td-agent/embedded/share/doc \
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,9 @@
tag kube-scheduler
</source>

<filter kubernetes.**>
type kubernetes_metadata
</filter>
#<filter kubernetes.**>
# type kubernetes_metadata
#</filter>

# Example:
# I0603 15:31:05.793605 6 cluster_manager.go:230] Reading config from path /etc/gce.conf
Expand Down
2 changes: 1 addition & 1 deletion cluster/addons/fluentd-gcp/fluentd-gcp-image/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
# scope and that the Logging API has been enabled for the project
# in the Google Developer Console.

FROM gcr.io/google_containers/ubuntu-slim:0.3
FROM gcr.io/google_containers/ubuntu-slim:0.4
MAINTAINER Alex Robinson "arob@google.com"

# Disable prompts from apt.
Expand Down
2 changes: 1 addition & 1 deletion cluster/addons/fluentd-gcp/fluentd-gcp-image/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

.PHONY: kbuild kpush

TAG = 1.22
TAG = 1.25

# Rules for building the test image for deployment to Dockerhub with user kubernetes.

Expand Down
2 changes: 1 addition & 1 deletion cluster/saltbase/salt/fluentd-es/fluentd-es.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ metadata:
spec:
containers:
- name: fluentd-elasticsearch
image: aledbf/fluentd-elasticsearch:1.19
image: gcr.io/google_containers/fluentd-elasticsearch:1.17
resources:
limits:
memory: 200Mi
Expand Down
2 changes: 1 addition & 1 deletion cluster/saltbase/salt/fluentd-gcp/fluentd-gcp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ spec:
dnsPolicy: Default
containers:
- name: fluentd-cloud-logging
image: aledbf/fluentd-gcp:1.22
image: gcr.io/google_containers/fluentd-gcp:1.21
resources:
limits:
memory: 200Mi
Expand Down

4 comments on commit e2c5015

@mindjiver
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I just wanted to check why the metadata plugin configuration was removed? It took me a while until i figured out that running the 1.17 version instead of 1.19 would decorate my data as expected!

@so0k
Copy link

@so0k so0k commented on e2c5015 Nov 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the salt was also moved back to version 1.17 instead of 1.19 ... this is one confusing commit @aledbf

@wangzhuzhen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to know why the metadata plugin configuration was removed?

@AlexRRR
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is all explained in detail in #33584

Please sign in to comment.