Make kubectl edit not convert GV on edits

Previously, kubectl edit was using a decoder to load in edits that converted to the internal version. It would then re-encode this decoded value to produce a patch. However, if you were editing in the object in a GroupVersion that was not the internal version, this would cause the kubectl edit command to attempt to produce a patch which changed the GroupVersion, which would fail. Now, we use a plain deserializer instead, so no conversion or defaulting occurs when loading in the edited file. Fixes #23378
kubernetes · Mar 24, 2016 · 95f08be · 95f08be · k8s-teamcity-mesosphere · Mar 24, 2016
1 parent f3af5d2
commit 95f08be
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/pkg/kubectl/cmd/edit.go b/pkg/kubectl/cmd/edit.go
@@ -120,12 +120,18 @@ func RunEdit(f *cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args
 		return err
 	}
 
+	// NB: we use `f.Decoder(false)` to get a plain deserializer for
+	// the resourceMapper, since it's used to read in edits and
+	// we don't want to convert into the internal version when
+	// reading in edits (this would cause us to potentially try to
+	// compare two different GroupVersions).
+
 	mapper, typer := f.Object()
 	resourceMapper := &resource.Mapper{
 		ObjectTyper:  typer,
 		RESTMapper:   mapper,
 		ClientMapper: resource.ClientMapperFunc(f.ClientForMapping),
-		Decoder:      f.Decoder(true),
+		Decoder:      f.Decoder(false),
 	}
 
 	r := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), f.Decoder(true)).