Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploying v1.6 clusters with kubeadm at HEAD is broken #289

Closed
luxas opened this issue Jun 6, 2017 · 2 comments · Fixed by kubernetes/kubernetes#46864
Closed

Deploying v1.6 clusters with kubeadm at HEAD is broken #289

luxas opened this issue Jun 6, 2017 · 2 comments · Fixed by kubernetes/kubernetes#46864
Assignees
@luxas
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.7

Comments

@luxas
Copy link
Member

luxas commented Jun 6, 2017

kubernetes/kubernetes#45619 completely removed the flag we used for auto-approval in v1.6 (--insecure-experimental-approve-all-kubelet-csrs-for-group=system:bootstrappers)

This "broke" deploying v1.6 clusters with kubeadm in the sense that kubeadm join will wait until you manually approve the CSR as there is no autoapprover configured.

The fix is pretty simple, we just need to check the version and use the right arguments for the right versions respectively.

PR: kubernetes/kubernetes#46864
@luxas luxas added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 6, 2017
@luxas luxas self-assigned this Jun 6, 2017
@luxas luxas added this to the v1.7 milestone Jun 6, 2017
@luxas luxas mentioned this issue Jun 6, 2017
Merged
@luxas luxas reopened this Jun 6, 2017
@timothysc
Copy link
Member

This merged, so I'm assuming it's all good?

@luxas
Copy link
Member Author

luxas commented Jun 9, 2017

Yup, now the second required PR merged as well so now it's working

@luxas luxas closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luxas luxas

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.7
Development

Successfully merging a pull request may close this issue.

kubeadm: Make kubeadm use the right CSR approver for the right version luxas/kubernetes
2 participants
@timothysc @luxas