-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt pod checkpointer #131
Comments
This task includes:
|
I am somewhat reluctant to moving the moving the code without making any use of it, what is the follow up accomplishment? If we are not so sure, may be we shouldn't do it until we are sure. |
First, move the code to kubernetes/kubeadm, and once we have the Makefile as well, @mikedanese will push the Docker image with that checkpointer inside and then we'll deploy it when using selfhosting and kuebadm. |
Also @aaronlevy mentioned that when this move is done, bootkube would be changed to use the upstream (this!) solution. |
Exactly! Both can take advantage of and experiment with it! |
What is the process for getting images built? That would be my only concern moving bootkube over (e.g. needing a fix but not being able to get an image built). But I don't want to have to manage changes between the code in two places - so ideally can move over to a single source of truth quickly. |
That can be a bottleneck frankly, since Googlers only have push access to gcr.io |
@timothysc is working on implementing this; it's tracked in a features issue as well: kubernetes/enhancements#378 |
@timothysc I'm moving this to v1.9 |
@timothysc we need to annotate the control plane manifests with the magic annotation if the self-hosting feature gate is set now, right? |
yes, add |
complete details are here - https://github.com/kubernetes/community/pull/1241/files |
This issue is listed as being in 1.9, can we have a status? It appears that there hasn't been any work on it in a while. |
Moved to v1.10 as discussed in the SIG |
@errordeveloper was going to re-look into the secrets issues and the multiple approaches. |
Closing, I have cleaner plans. |
Refs #127
The text was updated successfully, but these errors were encountered: