Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: kubernetes/klog
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.10.0
Choose a base ref
...
head repository: kubernetes/klog
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.20.0
Choose a head ref
  • 8 commits
  • 9 files changed
  • 5 contributors

Commits on Jul 5, 2021

  1. Configuration menu
    Copy the full SHA
    9ab3c2b View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Switching to logr tag v1.0.0

    Signed-off-by: Davanum Srinivas <davanum@gmail.com>
    dims committed Aug 3, 2021
    1 Configuration menu
    Copy the full SHA
    4171f3c View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. export ClearLogger

    Code in Kubernetes also needs the ability to unset a logger.
    pohly committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    8ee3d65 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #257 from pohly/clear-logger

    export ClearLogger
    k8s-ci-robot authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    74b1b2a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Merge pull request #250 from yuzhiquan/add-serathius-approver

    Proposal serathius as approvers
    k8s-ci-robot authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    e1f317b View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. fix file-based filtering symbolization

    If file-filtered logging is enabled, V looks up its caller's source
    file path using runtime.Callers and runtime.FuncForPC. However,
    runtime.Callers returns return PCs, which aren't necessarily in the
    same source file as the call site. For example, if F calls V, and F's
    call to V is immediately followed by an inlined called to another
    function, say G, then symbolizing V's return PC will actually return
    G's file and line number, not F's.
    
    Fix this by subtracting 1 from the PC returned by runtime.Callers to
    back up from the return PC to the call PC.
    
    An arguably better fix would be to use runtime.CallersFrames, which
    abstracts away such details. Unfortunately, CallersFrames allocates
    (at least as of Go 1.15), so we avoid it here.
    aclements authored and dims committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d648c2e View commit details
    Browse the repository at this point in the history
  2. Update to newest versions of golang 1.17.x

    Signed-off-by: Davanum Srinivas <davanum@gmail.com>
    dims committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    83653a6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #260 from dims/update-to-newest-versions-of-golang…

    …-1.17
    
    Update to newest versions of golang 1.17.x
    k8s-ci-robot authored Sep 2, 2021
    Configuration menu
    Copy the full SHA
    f8e668d View commit details
    Browse the repository at this point in the history
Loading