Update published modules with v0.x.y tags #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/M
liggitt
force-pushed
the
go-module-tags
branch
from
d71c31c to
17aa1b7
Compare
liggitt
changed the title
lavalamp
reviewed
Nov 1, 2019
|
+1 for me on this, thanks. |
pohly
reviewed
Nov 4, 2019
liggitt
force-pushed
the
go-module-tags
branch
from
17aa1b7 to
1441632
Compare
liggitt
force-pushed
the
go-module-tags
branch
from
1441632 to
8183d5b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM, agree with the approach. |
|
/approve /hold Please release hold when appropriate @liggitt |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
thanks, this is ready /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Not that I imagine it happen anytime soon, and I am +1 to this KEP, but does it not introduce a new barrier to cutting Kubernetes 2.x? Namely, we'll need to resolve go module tagging issues before being able to move to v2? This could probably also be resolved by something like adding 100 on to the minor version for each major version 🙄 which works, but also constrains us to having 'only' 100 minor releases in a single major release before we get conflicts 😅 |
|
For example: Kubernetes 1.12 = 0.12.Z (or maybe more helpfully: Kubernetes 2.12 = 0.212.Z 🤷♂) |
We would already have to do that, given the behavior of go1.13+ with major versions >= 2.x |
|
I think fixing our semver semantic is drastically easier than making
Kubernetes v2 :)
…On Fri, Nov 8, 2019 at 7:14 AM Jordan Liggitt ***@***.***> wrote:
Namely, we'll need to resolve go module tagging issues before being able
to move to v2?
We would already have to do that, given the behavior of go1.13+ with major
versions >= 2.x
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1350?email_source=notifications&email_token=AAE6BFTATHEL72FA74MCGALQSV65FA5CNFSM4JH67HMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDSM67Q#issuecomment-551866238>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE6BFT2A352CI4MX5PSSO3QSV65FANCNFSM4JH67HMA>
.
|
This was referenced Nov 11, 2019
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 4, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. Note that the old `kubernetes-1.x.y` tags are still also published. While publishing the `v0.x.y` tags, we ensure that we use the `v0.x.y` tags in go.mod as well (and not the pseudoversion).
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 5, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 5, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 5, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 5, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 5, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 6, 2019
Implements changes to the KEP in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
This was referenced Dec 6, 2019
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 6, 2019
Implements changes to the go modules KEP made in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 9, 2019
Implements changes to the go modules KEP made in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 10, 2019
Implements changes to the go modules KEP made in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 10, 2019
Implements changes to the go modules KEP made in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
nikhita
added a commit
to nikhita/publishing-bot
that referenced
this pull request
Dec 10, 2019
Implements changes to the go modules KEP made in kubernetes/enhancements#1350. This commit updates sync-tags to publish `v0.x.y` tags for corresponding `v1.x.y` Kubernetes tag. The old `kubernetes-1.x.y` tags are still also published. Both `kubernetes-1.x.y` and `v0.x.y` point to the same sha. For `v0.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. - When this tag is manually specified in a `go.mod` file, it will be retained as `v0.x.y`. For `kubernetes-1.x.y`: - At this tag, `go.mod` uses `v0.x.y` tags for dependencies. Note: this differs from the previous way, where pseudoversions were used. - When this tag is manually specified in a `go.mod` file, go will resolve it to the appropriate pseudoversion.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by discussion in kubernetes/kubernetes#84608
Specifically, see various scenarios in kubernetes/kubernetes#84608 (comment)
cc @sttts