-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure secret pulled images #2535
Comments
Thx @adisky |
/stage stable Note: Since this is a bugfix Mike would like to target graduation directly to stable. |
Hey @mikebrow, 1.22 Enhancements Lead here. 👋
@ehashman That should be fine so long as SIG Node are happy with that. (cc @dchen1107 @derekwaynecarr) I'm aware there's an open PR for your KEP open, but I'd just like to highlight a few things. By enhancements freeze (23:59:59 PST on Thursday 13th May) we require the following:
|
exception was filed last week.. no response yet. KEP updated to latest format and to resolve review questions (mainly added feature gate and switch to alpha vs going directly to GA. Code PR needs final reviews to go over the added feature gate. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Hi @adisky! 1.23 Enhancements team here. Just checking in as we approach enhancements freeze on Thursday 09/09. Here's where this enhancement currently stands:
Looks like for this one, we would need the following:
Also, could we please add some more information in the
Thank you! |
cc @mikebrow |
@adisky @Priyankasaggu11929 I updated the KEP adding a description for the test plan and links.. and updated the KEP's alpha target from 1.22 to 1.23. |
Thank you so much for adding the changes, @mikebrow. Just to confirm once:
Could you please confirm this part. Thanks once again. :) |
Yes, it is right to change the stage to alpha.
Forgot to hit the save button on those changes :-) Fixed now. Cheers, Mike |
Thanks for the changes @mikebrow :) |
Hello @mikebrow, just checking in as we approach 1.23 enhancements freeze tonight (09/09/2021, 23:59 PDT). Looks like the PR #1608 has got both Is it intended or can be removed to go ahead.? As with the PR merged, this enhancements will be ready for the 1.23 enhancements freeze tonight. Thank you! |
Just an update, the The KEP is now tracked for the kubernetes 1.23 release. Thank you so much @mikebrow. |
Hi, enhancements lead here - I inadvertently added this to the 1.32 tracking board 😀. Please readd it if you wish to progress this enhancement in 1.32. /remove-label lead-opted-in |
/milestone v1.32 |
Hello @adisky @haircommander 👋, Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 11th October 2024 / 19:00 PDT Thursday 10th October 2024. This enhancement is targeting for stage alpha for v1.32 (correct me, if otherwise). Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hello @impact-maker 👋 I believe your comment should be addressed by the changes in #4789, please take a look if the PRR questionnaire changes seem feasible to you. |
Hello @mikebrow , @haircommander @pacoxu , 👋🏼 this is Edith from the v1.32 Communications Team! We’d love for you to consider writing a feature blog about your enhancement! ✍ To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog, see the blog contribution guidelines. Note: In your placeholder PR, use XX characters for the blog date in the front matter and file name. We will work with you on updating the PR with the publication date once we have a final number of feature blogs for this release. |
Hi @adisky, @haircommander 👋, I'm James Spurin, a 1.32 Docs Shadow. Great to meet you. Does this enhancement work planned for 1.32 require any new docs or modifications to the existing docs? If so, please follows the steps here to open a PR against dev-1.32 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Thursday October 24th 2024 18:00 PDT. Also, take a look at Documenting for a release to familiarise with the docs requirement for the release. Thank you! |
Hi @adisky, @haircommander, @stlaz, I can see there are two references to blog posts and a closed PR from Nov 2023. Where applicable, please treat this as a reminder to open a placeholder PR against dev-1.32 branch in the k/website repo for this (steps available here) for this KEP if it requires new or modifications to existing docs. The deadline for this is Thursday Oct 24 at 18:00 PDT. Thanks! If you can confirm the status & direction, I will update the enhancements tracker for docs accordingly. Many Thanks James Spurin |
Hello @mikebrow , @haircommander @pacoxu ! 🙂 👋 This is a reminder to author your feature blog post! To opt-in, let us know and open a Feature Blog placeholder PR against the website repository by 30th Oct 2024. For more information about writing a blog see the blog contribution guidelines. Please feel free to reach out if you have any questions! Thank you very much! |
Hello @edithturn, |
Hello @stlaz! Thank you for your response. That is a great question! I keep track of each issue to check for replies from the owner, and they typically provide me with the link to the blog post once it’s created. Another way is to mention the blog post directly in my comment, like here. I'll keep an eye on it, and once you comment, I'll make sure it’s added to our dashboard I hope it answers your question! 🙂 |
Hey again @stlaz 👋 v1.32 Enhancements team here, Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024 . Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs are open and need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP): Additionally, please let me know if there are any other PRs in k/k not listed in the description or not linked with this GitHub issue that we should track for this KEP, so that we can maintain accurate status. The status of this enhancement is marked as If you anticipate missing code freeze, you can file an exception request in advance. Thank you! |
Hello @stlaz 👋 Enhancements team here, Unfortunately, the implementation (code related) PR(s) associated with this enhancement is not in the merge-ready state by code-freeze and hence this enhancement is now removed from the 1.32 milestone. If you still wish to progress this enhancement in 1.32, please file an exception request as soon as possible, within three days. If you have any questions, you can reach out in the #release-enhancements channel on Slack and we'll be happy to help. Thanks! /milestone clear |
Enhancement Description
IfNotPresent
image pull policyKubelet should enforce access to images after they've already been pulled to a node kubernetes#18787
k/enhancements
) update PR(s):k/k
) update PR(s):first try Ensure secret pulled images kubernetes#94899kubelet: ensure secret pulled image kubernetes#114847Implement KEP-2535 - Ensure secret pulled images feature kubernetes#125817k/website
) update PR(s):[WIP] Document KubeletEnsureSecretPulledImages feature website#43454blog: ensure secret pulled images website#45293Blog on "Ensure secret pulled images" feature website#47053Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
/sig node
The text was updated successfully, but these errors were encountered: