Adding huge page volume plugin. #764
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
| pre-allocated huge pages instead of THP. | ||
| pre-allocated huge pages instead of THP. | ||
|
|
||
| DPDK-based applications are going to request huge pages using `mmap()` system |
There was a problem hiding this comment.
Do we need to call out how we will ensure this is present/automate it ?
There was a problem hiding this comment.
Huge page volume plugin will make sure that this mount point will be present. Do you think I should add such comment?
| **Target 1.8+** | ||
|
|
||
| Implement huge page volume plugin. Accounting and limiting huge pages before | ||
| `Phase 2` can be done via OIR(opaque integer resources). |
There was a problem hiding this comment.
Will OIR be deprecated in favor of resource classes @vishh ? If so, is it ok to continue leveraging this for alpha features?
|
|
||
| // HugePagesSource represents Linux HugeTlbPage https://www.kernel.org/doc/Documentation/vm/hugetlbpage.txt | ||
| type HugePagesVolumeSource struct { | ||
| // Defaults to 2M |
There was a problem hiding this comment.
That is architecture specific - defaulting to /proc/meminfo Hugepagesize would allow the proposal to support different archs in the future.
There was a problem hiding this comment.
You're right I will change the proposal 😄
|
This addresses most of my feedback, but I would like an answer to the OIR question from Vish or Derek. |
|
this is fine. i want to take another pass over the whole proposal this week so we can get a full pr up and start knocking out the code. |
Adding support for applications requiring hugetlbfs.