Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eligible voters 2019-09-04 - 2019-09-09. #4074

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Add eligible voters 2019-09-04 - 2019-09-09. #4074

merged 1 commit into from
Sep 11, 2019

Conversation

mrbobbytables
Copy link
Member

Next round of eligible voters.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Sep 9, 2019
@castrojo
Copy link
Member

castrojo commented Sep 9, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: castrojo, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bgrant0607
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0611708 into kubernetes:master Sep 11, 2019
@mrbobbytables mrbobbytables deleted the add-voters-4 branch September 30, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607

@castrojo castrojo Awaiting requested review from castrojo

Assignees

@bgrant0607 bgrant0607

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrbobbytables @castrojo @k8s-ci-robot @bgrant0607