Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Shadow Role section for each events-team and Activities to Project Management events team #4017

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

hpandeycodeit
Copy link

  • Added Shadow Role section to each of the events-team Best Practices doc.
  • Added Activites to the Project Management Best Practices.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Aug 22, 2019
Copy link
Member

@tpepper tpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this is a useful addition. I've noted a two things which could use cleaning up.

@@ -32,6 +32,8 @@ As Marketing Lead, you are responsible for the overall marketing communications
- Determine signage needs and copy, coordinate with CNCF on explicit needs
- Create/update deck templates for curated talks and/or other purposes

## Shadow to the Marketing Lead Role
This role can include a shadow role as well. The Marketing Lead can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow to the Marketing Lead is responsible for handling all Registration lead related activities in the absence of the Lead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste error: should be "...responsible for handling all Marketing lead related activities..."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch :) fixed it.

* Ensure the overall event is a great experience for all contributors Recruit a core team (see best-practices.md) and help recruit other volunteers as necessary.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding a '.' in the middle of "...contributors Recruit..."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too. :)

@tpepper
Copy link
Member

tpepper commented Sep 17, 2019

Looks good to me. Would prefer a squash of the commits.

@hpandeycodeit
Copy link
Author

done.

Looks good to me. Would prefer a squash of the commits.

Copy link
Member

@tpepper tpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2019
@tpepper
Copy link
Member

tpepper commented Sep 20, 2019

/assign @cblecker

@cblecker
Copy link
Member

I don't know why the bot is suggesting me lol
/unassign
/assign @mrbobbytables @parispittman @jberkus

Copy link
Member

@mrbobbytables mrbobbytables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I've made a few small suggestions to the verbage to support one or more shadows 👍

@@ -32,6 +32,8 @@ As Marketing Lead, you are responsible for the overall marketing communications
- Determine signage needs and copy, coordinate with CNCF on explicit needs
- Create/update deck templates for curated talks and/or other purposes

## Shadow to the Marketing Lead Role
This role can include a shadow role as well. The Marketing Lead can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow to the Marketing Lead is responsible for handling all Marketing lead related activities in the absence of the Lead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This role can include a shadow role as well. The Marketing Lead can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow to the Marketing Lead is responsible for handling all Marketing lead related activities in the absence of the Lead.
This role can include one or more shadows. The Marketing Lead can delegate/assign tasks to the shadows. The expectation from a shadow is to lead one of the events-team roles in an upcoming summit. The shadows to the Marketing Lead are responsible for handling all Marketing lead related activities in the absence of the Lead.

Sort of little nitty stuff, but wanted to make it clear that we can support multiple shadows 👍

@@ -7,6 +7,9 @@ The Project Manager(s) is responsible for Triaging the project board, related is
Also, keep track of the timelines of these tasks and outlined activited.
The Project Manager role will ideally have a shadow for succession planning. Those who have been a part of a previous event get first dibs on lead roles to maintain consistency.

## Shadow to the Project Manager Role
This role can include a shadow role as well. The PM can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow is responsible for handling all Project Management related activities in the absence of the PM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This role can include a shadow role as well. The PM can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow is responsible for handling all Project Management related activities in the absence of the PM.
This role can include one or more shadows. The PM can delegate/assign tasks to the shadows. The expectation from a shadow is to lead one of the events-team roles in an upcoming summit. The shadows are responsible for handling all Project Management related activities in the absence of the PM.

Similar to the above, just some suggestions to make it clear that one or more shadows are possible 👍

@@ -43,6 +43,9 @@ A successful Registration lead should have the following qualities:
comfortable with queries and syntax is incredibly helpful, both for for the
registration approval process and later report generation.

## Shadow to the Registration Lead Role
This role can include a shadow role as well. The Registration Lead can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow to the Registration Lead is responsible for handling all Registration lead related activities in the absence of the Lead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This role can include a shadow role as well. The Registration Lead can delegate/assign the tasks to the shadow.The expectation from a shadow is to lead one of the events-team in the next summit. The shadow to the Registration Lead is responsible for handling all Registration lead related activities in the absence of the Lead.
This role can include one or more shadows. The Registration Lead can delegate/assign the tasks to the shadows. The expectation from a shadow is to lead one of the events-team roles in an upcoming summit. The shadows to the Registration Lead are responsible for handling all Registration lead related activities in the absence of the Lead.

More of the same 👍

@parispittman
Copy link
Contributor

thanks for this @hpandeycodeit!! happy to approve after @mrbobbytables comments are addressed

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@hpandeycodeit
Copy link
Author

Thanks @mrbobbytables @parispittman! I have made the requested changes :)

@mrbobbytables
Copy link
Member

Thanks @hpandeycodeit :)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2019
@parispittman
Copy link
Contributor

/approve

thank you so much!!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hpandeycodeit, parispittman, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8654726 into kubernetes:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants