Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement node synthetic ref #108

Merged
merged 10 commits into from
Dec 23, 2022
Merged

Implement node synthetic ref #108

merged 10 commits into from
Dec 23, 2022

Conversation

vassilvk
Copy link
Member

@vassilvk vassilvk commented Dec 12, 2022

Closes #107

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2022

Codecov Report

Base: 78.64% // Head: 76.58% // Decreases project coverage by -2.06% ⚠️

Coverage data is based on head (f77d6ad) compared to base (510da07).
Patch coverage: 72.86% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   78.64%   76.58%   -2.07%     
==========================================
  Files           8       14       +6     
  Lines         459     1059     +600     
==========================================
+ Hits          361      811     +450     
- Misses         70      183     +113     
- Partials       28       65      +37     
Impacted Files Coverage Δ
core/podbindingwebhook.go 0.00% <0.00%> (ø)
util/testlogger.go 0.00% <ø> (ø)
jsonpath/jsonpath.go 63.63% <63.63%> (ø)
jsonpath/placeholder.go 68.04% <68.04%> (ø)
core/dragnetwebhook.go 63.95% <74.62%> (+63.95%) ⬆️
jsonpath/selector.go 79.33% <79.33%> (ø)
core/modrulestoreitem.go 85.95% <80.00%> (+1.00%) ⬆️
jsonpath/parse.go 81.88% <81.88%> (ø)
core/modrulestore.go 87.63% <84.50%> (+3.97%) ⬆️
jsonpath/path.go 93.87% <93.87%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vassilvk vassilvk merged commit 95c43bc into master Dec 23, 2022
@vassilvk vassilvk deleted the 107-node-sythetic-ref branch December 24, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inject node manifest in syntheticRefs to make it visible in pod ModRules
2 participants