-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TF job v1 #993
TF job v1 #993
Conversation
Travis tests have failedHey @richardsliu, 1st Buildgo build -o tf-operator.v1 github.com/kubeflow/tf-operator/cmd/tf-operator.v1
gometalinter --config=linter_config.json --vendor ./...
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"
2nd Buildgo build -o tf-operator.v1 github.com/kubeflow/tf-operator/cmd/tf-operator.v1
gometalinter --config=linter_config.json --vendor ./...
goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"
TravisBuddy Request Identifier: 28300430-72c5-11e9-b281-3561ffbb4722 |
/assign @johnugeorge |
/retest |
2 similar comments
/retest |
/retest |
/retest |
1 similar comment
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
@@ -30,7 +30,7 @@ import ( | |||
|
|||
func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenAPIDefinition { | |||
return map[string]common.OpenAPIDefinition{ | |||
"github.com/kubeflow/tf-operator/pkg/apis/common/v1beta2.JobCondition": { | |||
"github.com/kubeflow/tf-operator/pkg/apis/common/v1.JobCondition": { | |||
Schema: spec.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
/retest |
1 similar comment
/retest |
/retest |
/lgtm |
Any CRD example for this version? |
@ScorpioCPH I will add them. |
Exact copy of v1beta2. Separate PR will be created to deprecate v1beta1.
Fixes #989
This change is