Add v1beta2 APIs and controller logic #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @richardsliu, 1st Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: 99d2b9b0-2a82-11e9-9562-95bccb7073f8 |
Travis tests have failedHey @richardsliu, 2nd Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: de1723f0-2a8b-11e9-bdf3-9bb996cd785e |
|
/test all |
richardsliu
changed the title
|
/lgtm |
johnugeorge
reviewed
Feb 7, 2019
| @@ -33,7 +33,7 @@ import ( | |||
| "k8s.io/kubernetes/pkg/api/legacyscheme" | |||
| "k8s.io/kubernetes/pkg/api/testapi" | |||
|
|
|||
| "github.com/kubeflow/tf-operator/pkg/common/util/testutil" | |||
| "github.com/kubeflow/tf-operator/pkg/common/util/v1beta2/testutil" | |||
There was a problem hiding this comment.
in the future, we have to restructure these tests. Common control package is currently using version specific testutil.
There was a problem hiding this comment.
Any way we can do this without duplicating common packages?
There was a problem hiding this comment.
Control packages are generic. It is not tied to TFJob. However, we added TF specific tests in control test packages.
Also, test utils package can be restructured to avoid duplication of entire code. We can take this up later.
There was a problem hiding this comment.
Opened #938 to track this.
|
/lgtm |
|
@richardsliu: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #935
This is an exact copy of the v1beta1 APIs and controller implementation. Future API changes will be made to the v1beta2 sub-folders.
Minor changes in directory structure:
pkg/common/utilis nowpkg/common/util/v1beta1andpkg/common/util/v1beta2.This change is